Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Label and Text to primer_react_css_modules_staff ship feature flag #5000

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Moving Label and Text to primer_react_css_modules_staff ship feature flag #5000

merged 3 commits into from
Sep 20, 2024
+42 −32

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 20, 2024 •
edited
Loading

Part of https://github.com/github/primer/issues/3785
Part of https://github.com/github/primer/issues/3914

Changelog

Changed

  • Label component CSS module feature flag changed to primer_react_css_modules_staff
  • Text component CSS module feature flag changed to primer_react_css_modules_staff

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0183655

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 20, 2024
@jonrohan jonrohan marked this pull request as ready for review September 20, 2024 18:39
@jonrohan jonrohan requested a review from a team as a code owner September 20, 2024 18:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.84 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 98.07 KB (-0.11% 🔽)

@jonrohan jonrohan added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit b8f6888 Sep 20, 2024
32 checks passed
@jonrohan jonrohan deleted the move_label_text_to_staff_ship branch September 20, 2024 21:02
@primer primer bot mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack