Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Select panel announcements #4927

Closed
wants to merge 101 commits into from
Closed

WIP: Select panel announcements #4927

wants to merge 101 commits into from

Commits on Jul 30, 2024

  1. super wip

    @broccolinisoup
    broccolinisoup committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9cee0a4 View commit details
    Browse the repository at this point in the history

  2. just use the actionlist component and revert the type updates

    @broccolinisoup
    broccolinisoup committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c7aa5de View commit details
    Browse the repository at this point in the history

  3. Update packages/react/src/FilteredActionList/FilteredActionList.tsx

    @broccolinisoup
    broccolinisoup committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    40a0c45 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Some more progress

    @broccolinisoup
    broccolinisoup committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    344f6ce View commit details
    Browse the repository at this point in the history

  2. revert the type changes and cast it :/

    @broccolinisoup
    broccolinisoup committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fa5f5a6 View commit details
    Browse the repository at this point in the history

  3. clean

    @broccolinisoup
    broccolinisoup committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3cd9ecc View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. wip

    @broccolinisoup
    broccolinisoup committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0003e59 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. wip wip

    @broccolinisoup
    broccolinisoup committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    713b5ad View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. add stories

    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6fc7f2b View commit details
    Browse the repository at this point in the history

  2. fix linting

    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a246981 View commit details
    Browse the repository at this point in the history

  3. add tests for groups

    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e209f47 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into select-panel-action-list

    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    26cddc1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'select-panel-story-and-tests' into select-panel-action-… 

    …list
    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b1199fb View commit details
    Browse the repository at this point in the history

  6. Map groups

    @broccolinisoup
    broccolinisoup committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b669cff View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'main' into select-panel-story-and-tests

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1012662 View commit details
    Browse the repository at this point in the history

  2. Update story names for e2e tests

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    67dc5c9 View commit details
    Browse the repository at this point in the history

  3. oops remove unintended file

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c66feb5 View commit details
    Browse the repository at this point in the history

  4. update story name

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4fbb3c5 View commit details
    Browse the repository at this point in the history

  5. same - update story name

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2d5e2b2 View commit details
    Browse the repository at this point in the history

  6. disable animations

    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    cee7737 View commit details
    Browse the repository at this point in the history

  7. test(vrt): update snapshots

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9c972c3 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'select-panel-story-and-tests' into select-panel-action-… 

    …list
    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    17e4ca8 View commit details
    Browse the repository at this point in the history

  9. Update tests since new action list has different semantics for group … 

    …headings
    @broccolinisoup
    broccolinisoup committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    26b6fe6 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'main' into select-panel-action-list

    @broccolinisoup
    broccolinisoup committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    42c50c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. logging

    @broccolinisoup
    broccolinisoup committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0d0004f View commit details
    Browse the repository at this point in the history

  2. pass the rest

    @broccolinisoup
    broccolinisoup committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3ba9bc7 View commit details
    Browse the repository at this point in the history

  3. extract children and use before text

    @broccolinisoup
    broccolinisoup committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    92ab9c2 View commit details
    Browse the repository at this point in the history

  4. remove logging

    @broccolinisoup
    broccolinisoup committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7b3d5e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'main' into select-panel-action-list

    @siddharthkp
    siddharthkp committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1cf1e09 View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    92303d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. add active styles to ActionList

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4dc3b41 View commit details
    Browse the repository at this point in the history

  2. rename component name to be clearer

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f673034 View commit details
    Browse the repository at this point in the history

  3. remove variant full from examples

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3a7d490 View commit details
    Browse the repository at this point in the history

  4. tiny clean up

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ab3ea9c View commit details
    Browse the repository at this point in the history

  5. fix showItemDividers

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    44ff862 View commit details
    Browse the repository at this point in the history

  6. another tiny cleanup

    @siddharthkp
    siddharthkp committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    46c94e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. pull MappedActionListItem to make it stable

    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ff8379b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into select-panel-action-list

    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9353d71 View commit details
    Browse the repository at this point in the history

  3. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0a126ad View commit details
    Browse the repository at this point in the history

  4. show active styles only when used with keyboard

    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    91cd5a3 View commit details
    Browse the repository at this point in the history

  5. backward compat: expose id as data-id

    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    40322c5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'select-panel-action-list' of github.com:primer/react in… 

    …to select-panel-action-list
    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f0150e4 View commit details
    Browse the repository at this point in the history

  7. update snapshots

    @siddharthkp
    siddharthkp committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f72b9d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. add story for long strings

    @siddharthkp
    siddharthkp committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    85d0237 View commit details
    Browse the repository at this point in the history

  2. fishing for errors

    @siddharthkp
    siddharthkp committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2eca9fa View commit details
    Browse the repository at this point in the history

  3. backward compatibility for renderItem

    @siddharthkp
    siddharthkp committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c875223 View commit details
    Browse the repository at this point in the history

  4. remove todo now

    @siddharthkp
    siddharthkp committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    02a6dc9 View commit details
    Browse the repository at this point in the history

  5. add a feature flag

    @siddharthkp
    siddharthkp committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    25c574a View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. clean up dual filter list setup

    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5dc6adb View commit details
    Browse the repository at this point in the history

  2. run jests test with both states of feature flags

    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    85e0bb4 View commit details
    Browse the repository at this point in the history

  3. refactor snapshot tests with scenarios

    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0ee74e1 View commit details
    Browse the repository at this point in the history

  4. remove feature flag for main

    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    798008e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into select-panel-action-list

    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    beca8db View commit details
    Browse the repository at this point in the history

  6. Merge branch 'selectpanel-prepare-scenarios' into select-panel-action… 

    …-list
    @siddharthkp
    siddharthkp committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    14fd206 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    185eb17 View commit details
    Browse the repository at this point in the history

  2. add feature flag to e2e matrix

    @siddharthkp
    siddharthkp committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    318aa99 View commit details
    Browse the repository at this point in the history

  3. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e9c523c View commit details
    Browse the repository at this point in the history

  4. backward compat: allow groupMetadata to be empty array

    @siddharthkp
    siddharthkp committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    efd1216 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'select-panel-action-list' of github.com:primer/react in… 

    …to select-panel-action-list
    @siddharthkp
    siddharthkp committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cd9a931 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'main' into select-panel-action-list

    @siddharthkp
    siddharthkp committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    619ff96 View commit details
    Browse the repository at this point in the history

  2. sigh newline

    @siddharthkp
    siddharthkp committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e3fe7b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Create sour-cooks-dress.md

    @siddharthkp
    siddharthkp committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ebac341 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into select-panel-action-list

    @siddharthkp
    siddharthkp committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0513474 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. copy SelectPanel snapshots from main

    @siddharthkp
    siddharthkp committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2afa236 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. remove unrelated changes in this PR

    @siddharthkp
    siddharthkp committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0f38bf4 View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f72aa55 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. set active styles for both active-descendant types

    @siddharthkp
    siddharthkp committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6e9d706 View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0b57206 View commit details
    Browse the repository at this point in the history

  3. Add built-in "no matches" item

    @siddharthkp
    siddharthkp committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    68d8cac View commit details
    Browse the repository at this point in the history

  4. deprecated FilteredList: Add built-in "no matches"

    @siddharthkp
    siddharthkp committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    cd18521 View commit details
    Browse the repository at this point in the history

  5. simpler code

    @siddharthkp
    siddharthkp committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    279cdbc View commit details
    Browse the repository at this point in the history

  6. Create mighty-doors-beg.md

    @siddharthkp
    siddharthkp committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6feec30 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. add test for no results

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0bf75ff View commit details
    Browse the repository at this point in the history

  2. add story and e2e test

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1526ec2 View commit details
    Browse the repository at this point in the history

  3. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3f5db33 View commit details
    Browse the repository at this point in the history

  4. brute force announcements

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2e933c8 View commit details
    Browse the repository at this point in the history

  5. abstract announcements, add to both

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    24b9805 View commit details
    Browse the repository at this point in the history

  6. add comment for context

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9ed9c42 View commit details
    Browse the repository at this point in the history

  7. use text instead of text content

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b050329 View commit details
    Browse the repository at this point in the history

  8. add selection state to announceInitialFocus

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    959a509 View commit details
    Browse the repository at this point in the history

  9. add selected state to announcement

    @siddharthkp
    siddharthkp committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    be47413 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. make announcements a one line string

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    55a8100 View commit details
    Browse the repository at this point in the history

  2. add tests (including failing)

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0a484e3 View commit details
    Browse the repository at this point in the history

  3. use getLiveRegion helper everyone

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7dc0543 View commit details
    Browse the repository at this point in the history

  4. calculate item index by looking at optionElements

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6229793 View commit details
    Browse the repository at this point in the history

  5. better punctuation

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f7766b8 View commit details
    Browse the repository at this point in the history

  6. update test to include updates

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    436a08b View commit details
    Browse the repository at this point in the history

  7. remove only

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    45abe7d View commit details
    Browse the repository at this point in the history

  8. expand type for old filtered actionlist

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    932f3a4 View commit details
    Browse the repository at this point in the history

  9. add timeout to help tests

    @siddharthkp
    siddharthkp committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d9268a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'main' into select-panel-no-matches

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b3ffdf8 View commit details
    Browse the repository at this point in the history

  2. remove changes from deprecated ActionList

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    996d446 View commit details
    Browse the repository at this point in the history

  3. remove test for no results

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b024e01 View commit details
    Browse the repository at this point in the history

  4. update changelog

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    db45eaa View commit details
    Browse the repository at this point in the history

  5. remove unused variable

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    70023e6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'select-panel-no-matches' into select-panel-announcements

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3d016c7 View commit details
    Browse the repository at this point in the history

  7. remove changes from deprecated version

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    83937c2 View commit details
    Browse the repository at this point in the history

  8. Create small-melons-fail.md

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7754ed9 View commit details
    Browse the repository at this point in the history

  9. always use data-is-active-descendant, not first

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8539ff8 View commit details
    Browse the repository at this point in the history

  10. abstractionssss

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ac79865 View commit details
    Browse the repository at this point in the history

  11. type veiligheid

    @siddharthkp
    siddharthkp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0008445 View commit details
    Browse the repository at this point in the history