Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental/SelectPanel v2: Fix heading color #4757

Merged
merged 3 commits into from
Jul 22, 2024
Merged

experimental/SelectPanel v2: Fix heading color #4757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f857b4
set default foreground color for dialog
siddharthkp Jul 19, 2024
8b635c4
Create real-bees-vanish.md
siddharthkp Jul 19, 2024
b3ceb77
test(vrt): update snapshots
siddharthkp Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-bees-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

experimental/SelectPanel v2: Fix heading color for dark themes
Binary file modified ...ectPanel.test.ts-snapshots/drafts-SelectPanel-Default-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../SelectPanel.test.ts-snapshots/drafts-SelectPanel-Default-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Panel.test.ts-snapshots/drafts-SelectPanel-Default-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../drafts/SelectPanel.test.ts-snapshots/drafts-SelectPanel-Default-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ectPanel.test.ts-snapshots/drafts-SelectPanel-Default-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/react/src/drafts/SelectPanel2/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ const Panel: React.FC<SelectPanelProps> = ({
// reset dialog default styles
border: 'none',
padding: 0,
color: 'fg.default',
'&[open]': {display: 'flex'}, // to fit children

'&[data-variant="anchored"], &[data-variant="full-screen"]': {
Expand Down
Loading