Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote PageHeader to Beta 🎉 #4725

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Promote PageHeader to Beta 🎉 #4725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
706edb2
Promote PageHeader to Beta
broccolinisoup Jul 9, 2024
ce3bde1
circular deps fix
broccolinisoup Jul 9, 2024
b68d7c3
Create nice-forks-joke.md
broccolinisoup Jul 9, 2024
bd50d08
fix e2e tests story name
broccolinisoup Jul 15, 2024
e2e6071
Update packages/react/src/PageHeader/PageHeader.docs.json
broccolinisoup Jul 15, 2024
1daae62
Update .changeset/nice-forks-joke.md
broccolinisoup Jul 15, 2024
1f12361
update test story names
broccolinisoup Jul 15, 2024
b89c7f5
back to Beta again
broccolinisoup Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-forks-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

PageHeader: Promote the component to Beta status and now it is available to import from "@primer/react"
broccolinisoup marked this conversation as resolved.
Show resolved Hide resolved
80 changes: 40 additions & 40 deletions e2e/components/PageHeader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--files-page',
id: 'components-pageheader-examples--files-page',
globals: {
colorScheme: theme,
},
Expand All @@ -21,7 +21,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--files-page',
id: 'components-pageheader-examples--files-page',
globals: {
colorScheme: theme,
},
Expand All @@ -43,7 +43,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--files-page-on-narrow-viewport',
id: 'components-pageheader-examples--files-page-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -55,7 +55,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--files-page-on-narrow-viewport',
id: 'components-pageheader-examples--files-page-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -77,7 +77,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--pull-request-page',
id: 'components-pageheader-examples--pull-request-page',
globals: {
colorScheme: theme,
},
Expand All @@ -89,7 +89,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--pull-request-page',
id: 'components-pageheader-examples--pull-request-page',
globals: {
colorScheme: theme,
},
Expand All @@ -116,7 +116,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--pull-request-page-on-narrow-viewport',
id: 'components-pageheader-examples--pull-request-page-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -130,7 +130,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--pull-request-page-on-narrow-viewport',
id: 'components-pageheader-examples--pull-request-page-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -157,7 +157,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--webhooks',
id: 'components-pageheader-examples--webhooks',
globals: {
colorScheme: theme,
},
Expand All @@ -169,7 +169,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--webhooks',
id: 'components-pageheader-examples--webhooks',
globals: {
colorScheme: theme,
},
Expand All @@ -191,7 +191,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--webhooks-on-narrow-viewport',
id: 'components-pageheader-examples--webhooks-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -203,7 +203,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--webhooks-on-narrow-viewport',
id: 'components-pageheader-examples--webhooks-on-narrow-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -225,7 +225,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--with-page-layout',
id: 'components-pageheader-examples--with-page-layout',
globals: {
colorScheme: theme,
},
Expand All @@ -237,7 +237,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-examples--with-page-layout',
id: 'components-pageheader-examples--with-page-layout',
globals: {
colorScheme: theme,
},
Expand All @@ -263,7 +263,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--has-large-title',
id: 'components-pageheader-features--has-large-title',
globals: {
colorScheme: theme,
},
Expand All @@ -275,7 +275,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--has-large-title',
id: 'components-pageheader-features--has-large-title',
globals: {
colorScheme: theme,
},
Expand All @@ -297,7 +297,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--has-title-only',
id: 'components-pageheader-features--has-title-only',
globals: {
colorScheme: theme,
},
Expand All @@ -309,7 +309,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--has-title-only',
id: 'components-pageheader-features--has-title-only',
globals: {
colorScheme: theme,
},
Expand All @@ -331,7 +331,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-actions',
id: 'components-pageheader-features--with-actions',
globals: {
colorScheme: theme,
},
Expand All @@ -343,7 +343,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-actions',
id: 'components-pageheader-features--with-actions',
globals: {
colorScheme: theme,
},
Expand All @@ -365,7 +365,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-actions-that-have-responsive-content',
id: 'components-pageheader-features--with-actions-that-have-responsive-content',
globals: {
colorScheme: theme,
},
Expand All @@ -379,7 +379,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-actions-that-have-responsive-content',
id: 'components-pageheader-features--with-actions-that-have-responsive-content',
globals: {
colorScheme: theme,
},
Expand All @@ -401,7 +401,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-context-bar-and-actions-of-context-area',
id: 'components-pageheader-features--with-context-bar-and-actions-of-context-area',
globals: {
colorScheme: theme,
},
Expand All @@ -415,7 +415,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-context-bar-and-actions-of-context-area',
id: 'components-pageheader-features--with-context-bar-and-actions-of-context-area',
globals: {
colorScheme: theme,
},
Expand All @@ -437,7 +437,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-custom-navigation',
id: 'components-pageheader-features--with-custom-navigation',
globals: {
colorScheme: theme,
},
Expand All @@ -449,7 +449,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-custom-navigation',
id: 'components-pageheader-features--with-custom-navigation',
globals: {
colorScheme: theme,
},
Expand All @@ -471,7 +471,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-description-slot',
id: 'components-pageheader-features--with-description-slot',
globals: {
colorScheme: theme,
},
Expand All @@ -483,7 +483,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-description-slot',
id: 'components-pageheader-features--with-description-slot',
globals: {
colorScheme: theme,
},
Expand All @@ -505,7 +505,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-and-trailing-actions',
id: 'components-pageheader-features--with-leading-and-trailing-actions',
globals: {
colorScheme: theme,
},
Expand All @@ -517,7 +517,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-and-trailing-actions',
id: 'components-pageheader-features--with-leading-and-trailing-actions',
globals: {
colorScheme: theme,
},
Expand All @@ -539,7 +539,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-and-trailing-visuals',
id: 'components-pageheader-features--with-leading-and-trailing-visuals',
globals: {
colorScheme: theme,
},
Expand All @@ -551,7 +551,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-and-trailing-visuals',
id: 'components-pageheader-features--with-leading-and-trailing-visuals',
globals: {
colorScheme: theme,
},
Expand All @@ -573,7 +573,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
id: 'components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -587,7 +587,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
id: 'components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
globals: {
colorScheme: theme,
},
Expand All @@ -609,7 +609,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-navigation-slot',
id: 'components-pageheader-features--with-navigation-slot',
globals: {
colorScheme: theme,
},
Expand All @@ -621,7 +621,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-navigation-slot',
id: 'components-pageheader-features--with-navigation-slot',
globals: {
colorScheme: theme,
},
Expand All @@ -643,7 +643,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-parent-link-and-actions-of-context-area',
id: 'components-pageheader-features--with-parent-link-and-actions-of-context-area',
globals: {
colorScheme: theme,
},
Expand All @@ -657,7 +657,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-features--with-parent-link-and-actions-of-context-area',
id: 'components-pageheader-features--with-parent-link-and-actions-of-context-area',
globals: {
colorScheme: theme,
},
Expand All @@ -679,7 +679,7 @@ test.describe('PageHeader', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
id: 'components-pageheader-devonly--large-variant-with-multiline-title',
globals: {
colorScheme: theme,
},
Expand All @@ -691,7 +691,7 @@ test.describe('PageHeader', () => {

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
id: 'components-pageheader-devonly--large-variant-with-multiline-title',
globals: {
colorScheme: theme,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.dev.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {GitBranchIcon, PencilIcon, SidebarExpandIcon} from '@primer/octicons-rea
import {PageHeader} from './PageHeader'

const meta: Meta<typeof PageHeader> = {
title: 'Drafts/Components/PageHeader/DevOnly',
title: 'Components/PageHeader/DevOnly',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/PageHeader/PageHeader.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"id": "drafts_page_header",
"name": "PageHeader",
"status": "draft",
"status": "beta",
broccolinisoup marked this conversation as resolved.
Show resolved Hide resolved
"a11yReviewed": true,
"stories": [],
"importPath": "@primer/react/experimental",
"importPath": "@primer/react",
"props": [
{
"name": "aria-label",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {ActionMenu} from '../ActionMenu'
import {ActionList} from '../ActionList'

const meta: Meta = {
title: 'Drafts/Components/PageHeader/Examples',
title: 'Components/PageHeader/Examples',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
Loading
Loading