Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavList: Only render the group title if title exists #4614

Merged
merged 1 commit into from
May 21, 2024

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented May 21, 2024

While testing PageHeader integration at dotcom, I came across an axe violation error (internally accessible only)

Headings should not be empty (empty-heading)

and realised that it was introduced by #4593 (Apologies!) - This PR fixes it.

Disclaimer: I don't think the title prop should be optional in terms of the accessibility requirements since each group needs to have a heading regardless it is visible or not but I'll raise an issue for this.

Changelog

New

Changed

  • Conditionally render the heading component. I.e. only when title exists

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; Since the main PR hasn't released yet and it has a changeset, I think it is fine to skip changeset here.

Testing & Reviewing

Merge checklist

@broccolinisoup broccolinisoup requested a review from a team as a code owner May 21, 2024 04:09
Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: 6e24806

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.56 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 88.9 KB (+0.07% 🔺)

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label May 21, 2024
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@siddharthkp siddharthkp added this pull request to the merge queue May 21, 2024
@siddharthkp siddharthkp mentioned this pull request May 21, 2024
4 tasks
Merged via the queue into main with commit f293344 May 21, 2024
36 of 37 checks passed
@siddharthkp siddharthkp deleted the navlist-as-prop-fix branch May 21, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants