NavList: Only render the group title if title exists #4614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing PageHeader integration at dotcom, I came across an axe violation error (internally accessible only)
and realised that it was introduced by #4593 (Apologies!) - This PR fixes it.
Disclaimer: I don't think the
title
prop should be optional in terms of the accessibility requirements since each group needs to have a heading regardless it is visible or not but I'll raise an issue for this.Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist