Only sets aria-labelledby to button label node only if loading is true

[mperrotti]

Changelog

New

N/A

Changed

Button and IconButton only use aria-labelledby to preserve the button label in a loading state OR if aria-labelledBy was explicitly passed.

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• [N/A] Added/updated documentation
• [N/A] Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: d645b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	89.03 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js	89.27 KB (-0.02% 🔽)

[joshblack]

LGTM, will defer to @TylerJDev 👀

Random question, if we are both loading and aria-labelledby is passed as a prop should we have both or is it okay to just have the id for the container with the loading label?

[TylerJDev]

Looks good! 🎉

Random question, if we are both loading and aria-labelledby is passed as a prop should we have both or is it okay to just have the id for the container with the loading label?

Part of me feels like it should defer to the prop aria-labelledby if one is available. I'm thinking of icon buttons which don't contain any text content, but are linked to text via aria-labelledby. An example of this could be the loading state of IconButton, but if it contained a label that it linked with aria-labelledby.

[mperrotti]

Closing this because I'm moving these changes over to a different PR: #4485