Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DataTable): add stories under drafts #3832

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

joshblack
Copy link
Member

Context: https://github.slack.com/archives/CSGAVNZ19/p1697474553526629

DataTable was added to the non-namespaced group of stories under components when the component JSON project was underway as the drafts status had not been incorporated yet. With recent changes to the component JSON script, this meant that the URLs for DataTable were being generated incorrectly. This change brings back DataTable to the correct status for the component and updates the component docs JSON accordingly.

Changelog

New

Changed

  • Move DataTable to Drafts/Components/DataTable
  • Update DataTable.docs.json with new prefix

Removed

Rollout strategy

None

Testing & Reviewing

  • Verify new urls listed in docs.json exist in storybook

@joshblack joshblack requested review from a team and mperrotti October 16, 2023 17:08
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 307bbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.77 KB (0%)
dist/browser.umd.js 105.36 KB (0%)

@joshblack joshblack temporarily deployed to github-pages October 16, 2023 17:14 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3832 October 16, 2023 17:15 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshblack joshblack temporarily deployed to github-pages October 16, 2023 21:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3832 October 16, 2023 21:18 Inactive
@joshblack joshblack added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 4dbc972 Oct 17, 2023
29 checks passed
@joshblack joshblack deleted the docs/update-data-table-stories branch October 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants