Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate jest-matchmedia-mock #2217

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Remove duplicate jest-matchmedia-mock #2217

merged 2 commits into from
Aug 8, 2022

Conversation

jclem
Copy link
Contributor

@jclem jclem commented Aug 4, 2022

This removes a duplicate dependency in package.json.

@jclem jclem requested review from a team and rezrah August 4, 2022 20:41
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: daf749e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 72.93 KB (0%)
dist/browser.umd.js 73.3 KB (0%)

@jclem jclem temporarily deployed to github-pages August 4, 2022 20:47 Inactive
@jclem jclem temporarily deployed to github-pages August 4, 2022 20:47 Inactive
colebemis
colebemis approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you!

@colebemis colebemis added the skip changeset This change does not need a changelog label Aug 8, 2022
@colebemis colebemis merged commit 788d06a into main Aug 8, 2022
@colebemis colebemis deleted the jclem/remove-duplicate-dep branch August 8, 2022 23:54
@colebemis colebemis temporarily deployed to github-pages August 9, 2022 00:00 Inactive
@colebemis colebemis temporarily deployed to github-pages August 9, 2022 00:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@rezrah rezrah Awaiting requested review from rezrah

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jclem @colebemis