-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use primer/react-scripts toolchain #2046
Conversation
|
size-limit report 📦
|
</ThemeProvider> | ||
) | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this in every story, which creates nested ThemeProviders! Switching theme at the top level doesn't go all the way down :/
Needs some clean up after this PR is merged.
Huh, I wonder if it's related to these changes: #2083 |
This reverts commit 9fe5b92.
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Part of the toolchain for component development
Before we start asking other teams to start using the toolchain,
we should use it in internal repos to test the experience
Replaces local storybook setup with primer/react-scripts. Still allows for project specific customisation. See
.storybook/main.js
and.storybook/preview.js
The canary version is intentional, @primer/react-scripts is still a proof of concept and does not publish a stable version yet. The package name and script name might change.Now using stable version :)Similar PR in memex: https://github.com/github/memex/pull/9638