Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primer/react-scripts toolchain #2046

Closed
wants to merge 30 commits into from
Closed

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 25, 2022

Part of the toolchain for component development

puppers eating food

Before we start asking other teams to start using the toolchain,
we should use it in internal repos to test the experience

 

Replaces local storybook setup with primer/react-scripts. Still allows for project specific customisation. See .storybook/main.js and .storybook/preview.js

The canary version is intentional, @primer/react-scripts is still a proof of concept and does not publish a stable version yet. The package name and script name might change. Now using stable version :)

Similar PR in memex: https://github.com/github/memex/pull/9638

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022

⚠️ No Changeset found

Latest commit: 5d01542

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp changed the title Use primer/react-scripts Use primer/react-scripts toolchian Apr 25, 2022
@siddharthkp siddharthkp changed the title Use primer/react-scripts toolchian Use primer/react-scripts toolchain Apr 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 67.58 KB (-0.03% 🔽)
dist/browser.umd.js 67.98 KB (+0.01% 🔺)

@siddharthkp siddharthkp temporarily deployed to github-pages April 25, 2022 12:30 Inactive
@siddharthkp siddharthkp self-assigned this Apr 25, 2022
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Apr 25, 2022
@siddharthkp siddharthkp marked this pull request as ready for review April 25, 2022 12:33
@siddharthkp siddharthkp requested a review from a team April 25, 2022 12:33
@siddharthkp siddharthkp temporarily deployed to github-pages April 25, 2022 12:47 Inactive
@siddharthkp siddharthkp temporarily deployed to needs-approval April 25, 2022 12:52 Inactive
</ThemeProvider>
)
}
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this in every story, which creates nested ThemeProviders! Switching theme at the top level doesn't go all the way down :/

Needs some clean up after this PR is merged.

@siddharthkp siddharthkp marked this pull request as draft April 25, 2022 13:02
@siddharthkp siddharthkp temporarily deployed to github-pages April 25, 2022 13:09 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages June 1, 2022 13:51 Inactive
@colebemis
Copy link
Contributor

@colebemis Do you know why CI is failing on this, looks like an unrelated change but it doens't fail on main 🤔

Could be because of a potential eslint version change?

Huh, I wonder if it's related to these changes: #2083

@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 17, 2022
@github-actions github-actions bot closed this Sep 24, 2022
@github-actions github-actions bot deleted the siddharth/primer-scripts branch September 24, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react skip changeset This change does not need a changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants