Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy Label component #1889

Merged
merged 19 commits into from
Mar 1, 2022
Merged

Conversation

mperrotti
Copy link
Contributor

These changes deprecate the legacy Label component, and graduates the new Label component from drafts/

@mperrotti mperrotti requested review from a team and rezrah February 24, 2022 21:23
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

🦋 Changeset detected

Latest commit: cf2e973

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 62.95 KB (+0.03% 🔺)
dist/browser.umd.js 63.28 KB (+0.01% 🔺)

'@primer/react': major
---

![NewLabels](https://user-images.githubusercontent.com/2313998/155384037-8a56c943-4cff-4349-925b-dc28247e3491.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOO shiny ✨ ... We should do this for the other components too if we're doing this here. Thoughts @mperrotti?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean show all the variations? That might not fit neatly into 1 header image 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, no I meant other components being deprecated in v35 don't have header images in their release notes, so this will stand out. We should either do it for all, or not at all IMO.

docs/content/Label.mdx Outdated Show resolved Hide resolved
@@ -77,8 +77,6 @@
url: /Header
- title: Heading
url: /Heading
- title: Label
Copy link
Contributor

@rezrah rezrah Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removing / hiding this intentional? I imagine we'd want to surface this component publically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentional 🙈


```javascript live noinline
render(
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't rendering correctly in the docs. I imagine it's because next branch hasn't been pulled in yet?
Screenshot 2022-02-25 at 12 41 19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because the next branch isn't pulled in yet. It's currently rendering the legacy Label

src/drafts/index.ts Outdated Show resolved Hide resolved
mperrotti and others added 2 commits February 25, 2022 10:02
Co-authored-by: Rez <rezrah@github.com>
Co-authored-by: Rez <rezrah@github.com>
Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ with one remaining 💬 #1889 (comment)

@siddharthkp
Copy link
Member

siddharthkp commented Feb 28, 2022

Using this checklist for review

High level checks

  • Docs working (deprecated Label points to new Label)
  • Tests passing
  • Storybook working

User facing (should prioritise for release)

  • Add changelog

API:

  • Move from src/index to src/deprecated
  • Add @deprecated JSDoc annotation
  • promotion: Move from src/drafts to src/index

Docs:

  • Update status to deprecated in docs
  • Add 'deprecated' to doc code examples (for ChoiceInputField)
  • Add deprecation notice in docs
  • Move to deprecated section in docs/nav.yml
  • deprecation: Move to docs/deprecated/
  • promotion: Move from docs/drafts/ to docs/

Internal maintenance (not blocking, can tackle in a new PR)

  • deprecation: Move deprecated component to src/deprecated/
  • promotion: Rename component from Label2 to Label
  • Update import path in related components (don't think there are any dependants)

Tests

  • Move deprecated component to tests/deprecated/
  • Update import path in tests
  • Update test snapshots
  • promotion: Rename component from Label2 to Label

Storybook:

  • NA Update title in story meta "Deprecated components"
  • NA Move to stories/deprecated/
  • Update import path in stories of related components (can use deprecated too)

@mperrotti
Copy link
Contributor Author

@siddharthkp there are no Storybook stories to deprecate

@colebemis colebemis changed the base branch from next/v35.0.0 to next-major February 28, 2022 23:28
@mperrotti mperrotti merged commit e9b81fa into next-major Mar 1, 2022
@mperrotti mperrotti deleted the mp/deprecate-legacy-label branch March 1, 2022 17:10
colebemis added a commit that referenced this pull request Mar 9, 2022
* prepare integration branch

* Move deprecated components to deprecated folder (#1881)

* prepare integration branch

* Move deprecated components to deprecated folder

* Add subpath exports for deprecated

* Fix up the docs

* Remove dialog and formgroup components

* Fix up all the tests

* Create smooth-cameras-prove.md

Co-authored-by: Reza Rahman <rezrah@github.com>

* Prefix component with types exported from ActionList2 and ActionMenu2 (#1883)

* prefix component name to types

* add changeset

* Update .changeset/actionlist2-actionmenu2-prefix-types.md

Co-authored-by: Cole Bemis <colebemis@github.com>

Co-authored-by: Cole Bemis <colebemis@github.com>

* Export PageLayout from main bundle (#1882)

* Export PageLayout from main bundle

* Create odd-apes-guess.md

* Add PageLayout to sidenav

* Update .changeset/odd-apes-guess.md

Co-authored-by: Rez <rezrah@github.com>

* Update PageLayout docs

Co-authored-by: Rez <rezrah@github.com>

* Update release notes and add deprecation notices for SelectMenu and Dropdown (#1887)

* chore: add deprecation notices for SelectMenu and Dropdown

* fix: deprecated metadata scope in docs

* docs: update release notes for Flex and BorderBox

* docs: update release notes for Position

* chore: add deprecated scope to jsx snippets

* chore: add release notes for Dropdown deprecation

* chore: add Grid release notes

* update release notes

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* Revert "Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)" (#1896)

This reverts commit f366604.

* Deprecate ActionList v1 & Promote drafts/ActionList v2 (#1893)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* changelog oopsie

* fix docs copy

* Add @deprecated on deprecated/ActionList

* oopsie on the link

* PR feedback on deprecation message

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1897)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu v1 + Remove DropdownMenu v2 (#1898)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu

* Use deprecated Dropdown for theme switcher

* Delete drafts/DropdownMenu2

* Add changelog

* remove debug statement :)

* Fix code examples in changeset (#1901)

* Update .changeset/deprecate-actionlistv1-promote-actionlistv2.md

* Add linebreaks to changesets

* Button deprecation (#1908)

* Move old button to deprecated

* Move Button2 to main bundle

* Add migration docs

* More changes from the checklist

* More deprecation

* Update tests

* Add deprecated details

* Create many-roses-hammer.md

* Update .changeset/many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Update many-roses-hammer.md

* Update many-roses-hammer.md

* Update many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Deprecate components replaced by FormControl (#1888)

* moves InputField to deprecated package

* adds jsdoc comments for deprecation

* adds changeset

* fixes bad autoformatting in changeset

* fixes import path in test file

* addresses PR feedback

* fixes FormGroup import in test

* addresses PR feedback

* moves tests to depreacted directory

* removes docs header image

* fixes bad formatting in changelog markdown

* Revert "fix merge conflicts with main"

This reverts commit 363bb07, reversing
changes made to f94dcd3.

* Deprecate ChoiceFieldset and ChoiceInputField (#1900)

* deprecates ChoiceFieldset and ChoiceInputField

* update import paths in tests

* addresses more PR feedback

* fixes bad imports in docs

* updates outdated story and test

* moves components to deprecated directory

* fixes broken docs pages

* fixes bad formatting in changelog markdown

* minor tweaks

* moves deprecated notation for ChoiceInputField

* Deprecate legacy Label component (#1889)

* moves Label to deprecated bundle

* graduates Label2 to main bundle

* cleanup

* adds changeset

* fixes tests

* update legacy label snapshots

* Update .changeset/heavy-points-marry.md

Co-authored-by: Rez <rezrah@github.com>

* Update docs/content/Label.mdx

Co-authored-by: Rez <rezrah@github.com>

* addresses pr feedback

* adds Label back to sidebar

* updates tests, removes docs header image

* removes docs header image

* fixes tests

* resets changed test

Co-authored-by: Rez <rezrah@github.com>

* Move remaining deprecated components to src/deprecated (#1917)

* Move deprecated components to src/deprecated

* Fix imports for tests

* Various fixes for v35 (#1916)

* chore: ad-hoc fixes for next-major branch

* fix #1912 docs error

* docs: remove reference to system props

* Create changeset-for-1917.md (#1919)

* Add align prop on ActionMenu.Overlay to pass through to AnchoredOverlay (#1921)

* Allow ActionMenu.Overlay to pass through align prop to AnchoredOverlay

* Add align prop to docs

* Fix AnchoredOverlay docs

* add changeset

* ActionMenu.Button: Fix spacing between text and caret (#1922)

* Fix spacing between Text and caret for ActionMenu.Button

* Improve changelog

* fix margin after design review

* unrelated change

* Update ActionMenu docs (#1931)

* Button: Update active styles + use them for aria-expanded (#1915)

* Add aria-expanded styles for Button

* update default button active styles

* update snapshot for button

* Create healthy-dots-chew.md

* fix broken test following main merging conflict resolution

* Fixes for v35 (#1934)

* fix ActioMenu story

* backfill missing exports in root index

* fix package-lock

* add changeset

* v35: Remove type aliases for ActionList (#1937)

* Replace aliases for ActionList types

* export types for LinkItem

* update selection types

* Next major changeset edits (#1939)

* Remove unnecessary changesets

* Edit changesets

* Fixes for v35 (#1938)

* add missing root exports

* fix invalid export

* add missing fragments to changesets (#1940)

* Update changeset examples (#1941)

* Fix table in changeset

* Add missing comma

* Fix grid changeset

* Update button changeset

Co-authored-by: Reza Rahman <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Pavithra Kodmad <pksjce@github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
pksjce added a commit that referenced this pull request Mar 10, 2022
* prepare integration branch

* Move deprecated components to deprecated folder (#1881)

* prepare integration branch

* Move deprecated components to deprecated folder

* Add subpath exports for deprecated

* Fix up the docs

* Remove dialog and formgroup components

* Fix up all the tests

* Create smooth-cameras-prove.md

Co-authored-by: Reza Rahman <rezrah@github.com>

* Prefix component with types exported from ActionList2 and ActionMenu2 (#1883)

* prefix component name to types

* add changeset

* Update .changeset/actionlist2-actionmenu2-prefix-types.md

Co-authored-by: Cole Bemis <colebemis@github.com>

Co-authored-by: Cole Bemis <colebemis@github.com>

* Export PageLayout from main bundle (#1882)

* Export PageLayout from main bundle

* Create odd-apes-guess.md

* Add PageLayout to sidenav

* Update .changeset/odd-apes-guess.md

Co-authored-by: Rez <rezrah@github.com>

* Update PageLayout docs

Co-authored-by: Rez <rezrah@github.com>

* Update release notes and add deprecation notices for SelectMenu and Dropdown (#1887)

* chore: add deprecation notices for SelectMenu and Dropdown

* fix: deprecated metadata scope in docs

* docs: update release notes for Flex and BorderBox

* docs: update release notes for Position

* chore: add deprecated scope to jsx snippets

* chore: add release notes for Dropdown deprecation

* chore: add Grid release notes

* update release notes

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* Revert "Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)" (#1896)

This reverts commit f366604.

* Deprecate ActionList v1 & Promote drafts/ActionList v2 (#1893)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* changelog oopsie

* fix docs copy

* Add @deprecated on deprecated/ActionList

* oopsie on the link

* PR feedback on deprecation message

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1897)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu v1 + Remove DropdownMenu v2 (#1898)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu

* Use deprecated Dropdown for theme switcher

* Delete drafts/DropdownMenu2

* Add changelog

* remove debug statement :)

* Fix code examples in changeset (#1901)

* Update .changeset/deprecate-actionlistv1-promote-actionlistv2.md

* Add linebreaks to changesets

* Button deprecation (#1908)

* Move old button to deprecated

* Move Button2 to main bundle

* Add migration docs

* More changes from the checklist

* More deprecation

* Update tests

* Add deprecated details

* Create many-roses-hammer.md

* Update .changeset/many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Update many-roses-hammer.md

* Update many-roses-hammer.md

* Update many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Deprecate components replaced by FormControl (#1888)

* moves InputField to deprecated package

* adds jsdoc comments for deprecation

* adds changeset

* fixes bad autoformatting in changeset

* fixes import path in test file

* addresses PR feedback

* fixes FormGroup import in test

* addresses PR feedback

* moves tests to depreacted directory

* removes docs header image

* fixes bad formatting in changelog markdown

* Revert "fix merge conflicts with main"

This reverts commit 363bb07, reversing
changes made to f94dcd3.

* Deprecate ChoiceFieldset and ChoiceInputField (#1900)

* deprecates ChoiceFieldset and ChoiceInputField

* update import paths in tests

* addresses more PR feedback

* fixes bad imports in docs

* updates outdated story and test

* moves components to deprecated directory

* fixes broken docs pages

* fixes bad formatting in changelog markdown

* minor tweaks

* moves deprecated notation for ChoiceInputField

* Deprecate legacy Label component (#1889)

* moves Label to deprecated bundle

* graduates Label2 to main bundle

* cleanup

* adds changeset

* fixes tests

* update legacy label snapshots

* Update .changeset/heavy-points-marry.md

Co-authored-by: Rez <rezrah@github.com>

* Update docs/content/Label.mdx

Co-authored-by: Rez <rezrah@github.com>

* addresses pr feedback

* adds Label back to sidebar

* updates tests, removes docs header image

* removes docs header image

* fixes tests

* resets changed test

Co-authored-by: Rez <rezrah@github.com>

* Move remaining deprecated components to src/deprecated (#1917)

* Move deprecated components to src/deprecated

* Fix imports for tests

* Various fixes for v35 (#1916)

* chore: ad-hoc fixes for next-major branch

* fix #1912 docs error

* docs: remove reference to system props

* Create changeset-for-1917.md (#1919)

* Add align prop on ActionMenu.Overlay to pass through to AnchoredOverlay (#1921)

* Allow ActionMenu.Overlay to pass through align prop to AnchoredOverlay

* Add align prop to docs

* Fix AnchoredOverlay docs

* add changeset

* ActionMenu.Button: Fix spacing between text and caret (#1922)

* Fix spacing between Text and caret for ActionMenu.Button

* Improve changelog

* fix margin after design review

* unrelated change

* Update ActionMenu docs (#1931)

* Button: Update active styles + use them for aria-expanded (#1915)

* Add aria-expanded styles for Button

* update default button active styles

* update snapshot for button

* Create healthy-dots-chew.md

* fix broken test following main merging conflict resolution

* Fixes for v35 (#1934)

* fix ActioMenu story

* backfill missing exports in root index

* fix package-lock

* add changeset

* v35: Remove type aliases for ActionList (#1937)

* Replace aliases for ActionList types

* export types for LinkItem

* update selection types

* Next major changeset edits (#1939)

* Remove unnecessary changesets

* Edit changesets

* Fixes for v35 (#1938)

* add missing root exports

* fix invalid export

* add missing fragments to changesets (#1940)

* Update changeset examples (#1941)

* Fix table in changeset

* Add missing comma

* Fix grid changeset

* Update button changeset

Co-authored-by: Reza Rahman <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Pavithra Kodmad <pksjce@github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
mperrotti added a commit that referenced this pull request Mar 16, 2022
* prepare integration branch

* Move deprecated components to deprecated folder (#1881)

* prepare integration branch

* Move deprecated components to deprecated folder

* Add subpath exports for deprecated

* Fix up the docs

* Remove dialog and formgroup components

* Fix up all the tests

* Create smooth-cameras-prove.md

Co-authored-by: Reza Rahman <rezrah@github.com>

* Prefix component with types exported from ActionList2 and ActionMenu2 (#1883)

* prefix component name to types

* add changeset

* Update .changeset/actionlist2-actionmenu2-prefix-types.md

Co-authored-by: Cole Bemis <colebemis@github.com>

Co-authored-by: Cole Bemis <colebemis@github.com>

* Export PageLayout from main bundle (#1882)

* Export PageLayout from main bundle

* Create odd-apes-guess.md

* Add PageLayout to sidenav

* Update .changeset/odd-apes-guess.md

Co-authored-by: Rez <rezrah@github.com>

* Update PageLayout docs

Co-authored-by: Rez <rezrah@github.com>

* Update release notes and add deprecation notices for SelectMenu and Dropdown (#1887)

* chore: add deprecation notices for SelectMenu and Dropdown

* fix: deprecated metadata scope in docs

* docs: update release notes for Flex and BorderBox

* docs: update release notes for Position

* chore: add deprecated scope to jsx snippets

* chore: add release notes for Dropdown deprecation

* chore: add Grid release notes

* update release notes

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* Revert "Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)" (#1896)

This reverts commit f366604.

* Deprecate ActionList v1 & Promote drafts/ActionList v2 (#1893)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* changelog oopsie

* fix docs copy

* Add @deprecated on deprecated/ActionList

* oopsie on the link

* PR feedback on deprecation message

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1897)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu v1 + Remove DropdownMenu v2 (#1898)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu

* Use deprecated Dropdown for theme switcher

* Delete drafts/DropdownMenu2

* Add changelog

* remove debug statement :)

* Fix code examples in changeset (#1901)

* Update .changeset/deprecate-actionlistv1-promote-actionlistv2.md

* Add linebreaks to changesets

* Button deprecation (#1908)

* Move old button to deprecated

* Move Button2 to main bundle

* Add migration docs

* More changes from the checklist

* More deprecation

* Update tests

* Add deprecated details

* Create many-roses-hammer.md

* Update .changeset/many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Update many-roses-hammer.md

* Update many-roses-hammer.md

* Update many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Deprecate components replaced by FormControl (#1888)

* moves InputField to deprecated package

* adds jsdoc comments for deprecation

* adds changeset

* fixes bad autoformatting in changeset

* fixes import path in test file

* addresses PR feedback

* fixes FormGroup import in test

* addresses PR feedback

* moves tests to depreacted directory

* removes docs header image

* fixes bad formatting in changelog markdown

* Revert "fix merge conflicts with main"

This reverts commit 363bb07, reversing
changes made to f94dcd3.

* Deprecate ChoiceFieldset and ChoiceInputField (#1900)

* deprecates ChoiceFieldset and ChoiceInputField

* update import paths in tests

* addresses more PR feedback

* fixes bad imports in docs

* updates outdated story and test

* moves components to deprecated directory

* fixes broken docs pages

* fixes bad formatting in changelog markdown

* minor tweaks

* moves deprecated notation for ChoiceInputField

* Deprecate legacy Label component (#1889)

* moves Label to deprecated bundle

* graduates Label2 to main bundle

* cleanup

* adds changeset

* fixes tests

* update legacy label snapshots

* Update .changeset/heavy-points-marry.md

Co-authored-by: Rez <rezrah@github.com>

* Update docs/content/Label.mdx

Co-authored-by: Rez <rezrah@github.com>

* addresses pr feedback

* adds Label back to sidebar

* updates tests, removes docs header image

* removes docs header image

* fixes tests

* resets changed test

Co-authored-by: Rez <rezrah@github.com>

* Move remaining deprecated components to src/deprecated (#1917)

* Move deprecated components to src/deprecated

* Fix imports for tests

* Various fixes for v35 (#1916)

* chore: ad-hoc fixes for next-major branch

* fix #1912 docs error

* docs: remove reference to system props

* Create changeset-for-1917.md (#1919)

* Add align prop on ActionMenu.Overlay to pass through to AnchoredOverlay (#1921)

* Allow ActionMenu.Overlay to pass through align prop to AnchoredOverlay

* Add align prop to docs

* Fix AnchoredOverlay docs

* add changeset

* ActionMenu.Button: Fix spacing between text and caret (#1922)

* Fix spacing between Text and caret for ActionMenu.Button

* Improve changelog

* fix margin after design review

* unrelated change

* Update ActionMenu docs (#1931)

* Button: Update active styles + use them for aria-expanded (#1915)

* Add aria-expanded styles for Button

* update default button active styles

* update snapshot for button

* Create healthy-dots-chew.md

* fix broken test following main merging conflict resolution

* Fixes for v35 (#1934)

* fix ActioMenu story

* backfill missing exports in root index

* fix package-lock

* add changeset

* v35: Remove type aliases for ActionList (#1937)

* Replace aliases for ActionList types

* export types for LinkItem

* update selection types

* Next major changeset edits (#1939)

* Remove unnecessary changesets

* Edit changesets

* Fixes for v35 (#1938)

* add missing root exports

* fix invalid export

* add missing fragments to changesets (#1940)

* Update changeset examples (#1941)

* Fix table in changeset

* Add missing comma

* Fix grid changeset

* Update button changeset

* rms deprecated components and layout tweaks

* updates snaps

* adds changeset

* Update title and componentId of deprecated components

* Add missing component ids

* Remove link button docs

* Update dialog props

* Update nav.yml

* Update live code scope

Co-authored-by: Reza Rahman <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Pavithra Kodmad <pksjce@github.com>
pksjce added a commit that referenced this pull request Mar 17, 2022
* prepare integration branch

* Move deprecated components to deprecated folder (#1881)

* prepare integration branch

* Move deprecated components to deprecated folder

* Add subpath exports for deprecated

* Fix up the docs

* Remove dialog and formgroup components

* Fix up all the tests

* Create smooth-cameras-prove.md

Co-authored-by: Reza Rahman <rezrah@github.com>

* Prefix component with types exported from ActionList2 and ActionMenu2 (#1883)

* prefix component name to types

* add changeset

* Update .changeset/actionlist2-actionmenu2-prefix-types.md

Co-authored-by: Cole Bemis <colebemis@github.com>

Co-authored-by: Cole Bemis <colebemis@github.com>

* Export PageLayout from main bundle (#1882)

* Export PageLayout from main bundle

* Create odd-apes-guess.md

* Add PageLayout to sidenav

* Update .changeset/odd-apes-guess.md

Co-authored-by: Rez <rezrah@github.com>

* Update PageLayout docs

Co-authored-by: Rez <rezrah@github.com>

* Update release notes and add deprecation notices for SelectMenu and Dropdown (#1887)

* chore: add deprecation notices for SelectMenu and Dropdown

* fix: deprecated metadata scope in docs

* docs: update release notes for Flex and BorderBox

* docs: update release notes for Position

* chore: add deprecated scope to jsx snippets

* chore: add release notes for Dropdown deprecation

* chore: add Grid release notes

* update release notes

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* Revert "Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2  (#1895)" (#1896)

This reverts commit f366604.

* Deprecate ActionList v1 & Promote drafts/ActionList v2 (#1893)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* changelog oopsie

* fix docs copy

* Add @deprecated on deprecated/ActionList

* oopsie on the link

* PR feedback on deprecation message

* Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1897)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu v1 + Remove DropdownMenu v2 (#1898)

* Deprecate ActionList v1

* Promote drafts/ActionList2 to main/ActionList

* Add changelog

* Undo package-lock change

* update ActionList import for Menu2 docs

* Deprecate ActionMenu - part 1

* Deprecate ActionMenu - part 2

* Promote drafts/ActionMenu2 to main/ActionMenu

* Add changelog

* Add @deprecated on deprecated/ActionMenu

* docs fixed!

* reorder deprecated components alphabetically

* Update deprecation message

* Fix missing icon that only broke on this PR for some reason

* Deprecate DropdownMenu

* Use deprecated Dropdown for theme switcher

* Delete drafts/DropdownMenu2

* Add changelog

* remove debug statement :)

* Fix code examples in changeset (#1901)

* Update .changeset/deprecate-actionlistv1-promote-actionlistv2.md

* Add linebreaks to changesets

* Button deprecation (#1908)

* Move old button to deprecated

* Move Button2 to main bundle

* Add migration docs

* More changes from the checklist

* More deprecation

* Update tests

* Add deprecated details

* Create many-roses-hammer.md

* Update .changeset/many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Update many-roses-hammer.md

* Update many-roses-hammer.md

* Update many-roses-hammer.md

Co-authored-by: Rez <rezrah@github.com>

* Deprecate components replaced by FormControl (#1888)

* moves InputField to deprecated package

* adds jsdoc comments for deprecation

* adds changeset

* fixes bad autoformatting in changeset

* fixes import path in test file

* addresses PR feedback

* fixes FormGroup import in test

* addresses PR feedback

* moves tests to depreacted directory

* removes docs header image

* fixes bad formatting in changelog markdown

* Revert "fix merge conflicts with main"

This reverts commit 363bb07, reversing
changes made to f94dcd3.

* Deprecate ChoiceFieldset and ChoiceInputField (#1900)

* deprecates ChoiceFieldset and ChoiceInputField

* update import paths in tests

* addresses more PR feedback

* fixes bad imports in docs

* updates outdated story and test

* moves components to deprecated directory

* fixes broken docs pages

* fixes bad formatting in changelog markdown

* minor tweaks

* moves deprecated notation for ChoiceInputField

* Deprecate legacy Label component (#1889)

* moves Label to deprecated bundle

* graduates Label2 to main bundle

* cleanup

* adds changeset

* fixes tests

* update legacy label snapshots

* Update .changeset/heavy-points-marry.md

Co-authored-by: Rez <rezrah@github.com>

* Update docs/content/Label.mdx

Co-authored-by: Rez <rezrah@github.com>

* addresses pr feedback

* adds Label back to sidebar

* updates tests, removes docs header image

* removes docs header image

* fixes tests

* resets changed test

Co-authored-by: Rez <rezrah@github.com>

* Move remaining deprecated components to src/deprecated (#1917)

* Move deprecated components to src/deprecated

* Fix imports for tests

* Various fixes for v35 (#1916)

* chore: ad-hoc fixes for next-major branch

* fix #1912 docs error

* docs: remove reference to system props

* Create changeset-for-1917.md (#1919)

* Add align prop on ActionMenu.Overlay to pass through to AnchoredOverlay (#1921)

* Allow ActionMenu.Overlay to pass through align prop to AnchoredOverlay

* Add align prop to docs

* Fix AnchoredOverlay docs

* add changeset

* ActionMenu.Button: Fix spacing between text and caret (#1922)

* Fix spacing between Text and caret for ActionMenu.Button

* Improve changelog

* fix margin after design review

* unrelated change

* Update ActionMenu docs (#1931)

* Button: Update active styles + use them for aria-expanded (#1915)

* Add aria-expanded styles for Button

* update default button active styles

* update snapshot for button

* Create healthy-dots-chew.md

* fix broken test following main merging conflict resolution

* Fixes for v35 (#1934)

* fix ActioMenu story

* backfill missing exports in root index

* fix package-lock

* add changeset

* v35: Remove type aliases for ActionList (#1937)

* Replace aliases for ActionList types

* export types for LinkItem

* update selection types

* Next major changeset edits (#1939)

* Remove unnecessary changesets

* Edit changesets

* Fixes for v35 (#1938)

* add missing root exports

* fix invalid export

* add missing fragments to changesets (#1940)

* Update changeset examples (#1941)

* Fix table in changeset

* Add missing comma

* Fix grid changeset

* Update button changeset

* rms deprecated components and layout tweaks

* updates snaps

* adds changeset

* Update title and componentId of deprecated components

* Add missing component ids

* Remove link button docs

* Update dialog props

* Update nav.yml

* Update live code scope

Co-authored-by: Reza Rahman <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Pavithra Kodmad <pksjce@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants