-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: restore color prop functionality for StyledOcticon #1781
Conversation
🦋 Changeset detectedLatest commit: d40abc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Ship it
Sidenote: How does https://github.com/primer/eslint-plugin-primer-react know that it has to ignore |
Looking at the rule source, there's an exclusion but interestingly |
Trying to understand the source, are you referring to this line? rules/no-system-props.js#L66: let systemProps = Object.values(pick(propsByNameObject)) definition of pick: @styled-system/props/index.js#L45-L52 |
Restores
color
prop functionality toStyledOcticon
, which now works with both native and functional colours.Other changes:
Before
After
Merge checklist