Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SelectPanel from the package #1772

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Export SelectPanel from the package #1772

merged 4 commits into from
Jan 6, 2022

Conversation

pksjce
Copy link
Collaborator

@pksjce pksjce commented Jan 5, 2022

As described in #1768, SelectPanel is not exported nor is the documentation displayed.
But the component status page lists it as alpha.
Since it's quite an old component, I'm thinking we missed exporting it.

lmk if its otherwise.

@pksjce pksjce requested review from a team and rezrah January 5, 2022 07:51
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2022

🦋 Changeset detected

Latest commit: bc17241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 59.92 KB (+1.73% 🔺)
dist/browser.umd.js 60.28 KB (+1.76% 🔺)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@maximedegreve
Copy link
Contributor

This works! Just tested it. 🎉

@pksjce pksjce merged commit 52947c4 into main Jan 6, 2022
@pksjce pksjce deleted the pk/export-select-panel branch January 6, 2022 03:45
@primer-css primer-css mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants