Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SelectPanel Filter width #1742

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Fix for SelectPanel Filter width #1742

merged 4 commits into from
Dec 17, 2021

Conversation

pksjce
Copy link
Collaborator

@pksjce pksjce commented Dec 16, 2021

Describe your changes here.

SelectPanel uses TextInput with block prop. The diff previously was missing converting inline to block element when this boolean is present.

  • Added fix
  • Added relevant storybook (next time chromatic can catch this)

Closes #1741 #1741

Screenshots

Before
Screen Shot 2021-12-16 at 8 36 40 pm

After
Screen Shot 2021-12-16 at 8 36 49 pm

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@pksjce pksjce requested review from a team and rezrah December 16, 2021 09:43
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2021

🦋 Changeset detected

Latest commit: 2c2f426

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 57.5 KB (+0.02% 🔺)
dist/browser.umd.js 57.81 KB (+0.01% 🔺)

Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pksjce. You're just missing the patch changeset, but otherwise good to go.

:shipit:

@pksjce pksjce enabled auto-merge (squash) December 17, 2021 00:28
@pksjce pksjce merged commit 4ab78a2 into main Dec 17, 2021
@pksjce pksjce deleted the pk/select-text-fix branch December 17, 2021 00:35
@primer-css primer-css mentioned this pull request Dec 17, 2021
pksjce added a commit that referenced this pull request Dec 20, 2021
* Fix for SelectPanel Filter width

* Lint issues

* Create shaggy-hounds-decide.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectPanel Input styles seem off in 34.0.1
3 participants