-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "engines" field from package.json #1712
Conversation
🦋 Changeset detectedLatest commit: 2da1e52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is engines
supposed to be about what's needed to run the distributed package? Or is it about what's needed to build and contribute?
I think it's "what's needed to run the distributed package" because I couldn't install |
https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines
|
* Remove "engines" field from package.json * Create tidy-maps-care.md
The
engines
field is breaking builds for projects using node <16. Since node 16 is not required to use@primer/react
, let's remove this field from the package.json.