Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated components to a folder #1705

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

siddharthkp
Copy link
Member

Where does this show up:

  1. In search, the folder is showed in the search result, which would point people to the right component

image

  1. When you're in the component, in additional to the Deprecated label next to the title, it shows up in the URL as well.

image

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated documentation

@siddharthkp siddharthkp requested review from a team and jfuchs December 8, 2021 14:44
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2021

⚠️ No Changeset found

Latest commit: 949e65c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp self-assigned this Dec 8, 2021
@siddharthkp siddharthkp added docs Documentation react labels Dec 8, 2021
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 56.98 KB (0%)
dist/browser.umd.js 57.29 KB (0%)

@colebemis
Copy link
Contributor

Should we also move them into the deprecated section of the nav?
CleanShot 2021-12-08 at 08 35 47

@siddharthkp
Copy link
Member Author

@colebemis Yes! I forgot about those! my bad, fixed now!

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @siddharthkp!

Maybe not necessary for this PR, but we should link to the replacement components on deprecated component pages (e.g. Dialog should link to Dialog v2)

@siddharthkp
Copy link
Member Author

Maybe not necessary for this PR, but we should link to the replacement components on deprecated component pages (e.g. Dialog should link to Dialog v2)

Great idea, will create another PR

@siddharthkp siddharthkp merged commit b006063 into main Dec 9, 2021
@siddharthkp siddharthkp deleted the siddharth/docs-deprecated branch December 9, 2021 10:42
pksjce pushed a commit that referenced this pull request Dec 20, 2021
* Move deprecated components to a folder

* fix url + move deprecated components down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation react skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants