bump typescript package to latest version #1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a bug in the generated typings that seems to be tied to being on an old version of Typescript.
To reproduce it, run this command after building the package:
Without this fix, one of the errors you'll see is this:
I can reproduce this with three files under
lib
after building:I think this is just a fix for how
Pick<T, Key>
gets generated, as it seems like the generated types for these files all have this in common:With this version, you'll now see this as part of the signature:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.