Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectPanel): allow external anchor ref #1368

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Aug 4, 2021

SelectPanel currently creates an anchor internally, but has no option to anchor next to an outside ref. We added this "external anchor" feature to ActionMenu in #1199, but never added it to the other AnchoredOverlay wrappers. This is needed for some new menu behaviors being built by another team.

Screenshots

image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@dgreif dgreif requested a review from jfuchs August 4, 2021 22:57
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2021

🦋 Changeset detected

Latest commit: 518025a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 48.46 KB (0%)
dist/browser.umd.js 48.75 KB (0%)

Copy link
Contributor

@jfuchs jfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😻

@dgreif dgreif merged commit 36f156a into main Aug 5, 2021
@dgreif dgreif deleted the select-panel-anchor-ref branch August 5, 2021 17:37
@primer-css primer-css mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants