Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sizes for Overlay and Dialog #1238

Merged
merged 4 commits into from
May 21, 2021
Merged

New sizes for Overlay and Dialog #1238

merged 4 commits into from
May 21, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented May 19, 2021

Introducing new sizes for Overlay because the originals were designed with Dialog in mind. Since Dialog has it's own sizing, Overlay now has the opportunity to support a wider range.

Also switching from sm to small naming convention to match PVC and other places in PRC like Label. Still up in the air on the xLarge values. Should they be xLarge, extraLarge or xl?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dgreif dgreif requested a review from colebemis May 19, 2021 20:32
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2021

🦋 Changeset detected

Latest commit: 5e9a9b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/Fo7ZdmEXsD9BniwaHj4GrVaABpkd
✅ Preview: https://primer-components-git-overlay-sizing-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview May 19, 2021 21:16 Inactive
docs/content/Dialog2.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 21, 2021 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview May 21, 2021 17:49 Inactive
@dgreif dgreif enabled auto-merge (squash) May 21, 2021 17:53
@vercel vercel bot temporarily deployed to Preview May 21, 2021 17:54 Inactive
@dgreif dgreif merged commit 8368a83 into main May 21, 2021
@dgreif dgreif deleted the overlay-sizing branch May 21, 2021 17:56
@github-actions github-actions bot mentioned this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants