Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert link component to typescript #1011

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

VanAnderson
Copy link
Contributor

Describe your changes here.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/7hfdm1d5m
✅ Preview: https://primer-components-git-vananderson-convert-link-component.primer.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2021

🦋 Changeset detected

Latest commit: 2215a70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis mentioned this pull request Feb 3, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 3, 2021 19:30 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review February 3, 2021 19:44
@vercel vercel bot temporarily deployed to Preview February 3, 2021 19:48 Inactive
@VanAnderson
Copy link
Contributor Author

Ah, looks like I need to update some of the tests!

@vercel vercel bot temporarily deployed to Preview February 3, 2021 20:17 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vercel vercel bot temporarily deployed to Preview February 3, 2021 20:21 Inactive
@colebemis colebemis merged commit 2047322 into main Feb 3, 2021
@colebemis colebemis deleted the VanAnderson/convert-link-component branch February 3, 2021 20:28
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants