Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend a component #4

Closed
broccolini opened this issue Feb 20, 2018 · 0 comments
Closed

Extend a component #4

broccolini opened this issue Feb 20, 2018 · 0 comments
Assignees
@broccolini

Comments

@broccolini
Copy link
Member

Extend a component (such as buttons) to provide an example of how we'll approach this with any component, such as when do you extend vs add props.
@broccolini broccolini self-assigned this Feb 20, 2018
siddharthkp added a commit that referenced this issue Apr 10, 2024
@siddharthkp
Revert "Revert "Add loading prop for Button and IconButton (#3582…
60b3253 
…)" (#4…"

This reverts commit c01901f.
github-merge-queue bot pushed a commit that referenced this issue Jul 25, 2024
@mperrotti @siddharthkp
@khiga8 @broccolinisoup
Un-revert "Add loading prop for Button and IconButton (#3582)" (#…
991839c 
…4485)

* Revert "Revert "Add `loading` prop for `Button` and `IconButton` (#3582)" (#4…"

This reverts commit c01901f.

* only overrides btn label when loading

* update tooltip tests to accomodate loading message aria-describedby

* import missing modules in IconButton stories

* makes aria-labelledby prop remain set when when button is in a loading state

* Update packages/react/src/Button/Button.examples.stories.tsx

Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com>

* Update packages/react/src/Button/Button.examples.stories.tsx

Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com>

* updates textinput snapshots

* addresses remaining PR feedback

* appeases the linter, updates snaps

* leaves loading prop undefined so we do not always render the wrapper

* test(vrt): update snapshots

* trying again without changing colors on faux-disabled buttons

* replaces Status with AriaStatus

* replaces one more Status with AriaStatus

* rms added aria-disabled styles

* test(vrt): update snapshots

* Update icon button tests to make it work with the loading state

* add story with leading visual and count

* misc bugfixes:
- ensures counter stays rendered even when no children are passed
- preserves space between elements that are children of span[data-component=text]
- adds story and VRT for buttons with a trailing action but no leading/trailing visuals

* test(vrt): update snapshots

---------

Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com>
Co-authored-by: mperrotti <mperrotti@users.noreply.github.com>
Co-authored-by: Armagan Ersoz <broccolinisoup@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broccolini broccolini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@broccolini