-
Notifications
You must be signed in to change notification settings - Fork 534
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add trailingAction to TextInput (#1947)
* adds loading indicator to text inputs * removes style debugging div * updates stories and docs * updates tests * fixes silly test mistakes * revert default textinput story * adds changeset * Update src/TextInput.tsx Co-authored-by: Pavithra Kodmad <pksjce@github.com> * updates component API * adds trailing action to text input, tweaks formcontrol * addresses PR feedback * fixes linting error * indicate a busy status to assistive technology * updates snaps * renames 'isLoading' prop to 'loading' * Update docs/content/TextInput.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/TextInput.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/TextInput.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/TextInput.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/TextInput.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * updates snapshots * nests examples under an 'Examples' heading * export TextInput non-pass-through props * fix undefined type usage * fixes story types * rm unnecessary width style from formcontrol, fix formcontrol import * rm forgotten comment * adds changeset * silences linting error and rms bad imports * addresses PR feedback * rms redundant stories * removes excess right padding when we pass 'trailingAction' and 'loading' * change iconLabel to aria-label in docs example * empy commit to make CI run * disable html-addon to prevent Storybook from timing out Chromatic Co-authored-by: Pavithra Kodmad <pksjce@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
- Loading branch information
1 parent
310d215
commit edc85c9
Showing
13 changed files
with
1,703 additions
and
194 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@primer/react': minor | ||
--- | ||
|
||
Adds the option to render a trailing action inside of the TextInput component |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.