Skip to content

Commit

Permalink
Merge branch 'main' into fix-textinput-types
Browse files Browse the repository at this point in the history
  • Loading branch information
colebemis committed Mar 16, 2022
2 parents 2678bbc + 3f50ef5 commit d4d98cf
Show file tree
Hide file tree
Showing 39 changed files with 521 additions and 500 deletions.
5 changes: 5 additions & 0 deletions .changeset/seven-hornets-jam.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Adds button element selector to FilteredSearch button styles
5 changes: 5 additions & 0 deletions .changeset/stupid-terms-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Bump primer/primitives to `7.5.1`
5 changes: 5 additions & 0 deletions .changeset/yellow-planes-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Add disabled color and backgroundColor to Button.Counter
1 change: 1 addition & 0 deletions docs/content/CheckboxGroup.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: CheckboxGroup
componentId: checkbox_group
description: Renders a set of checkboxes to let users make one or more selections from a short list of options
status: Alpha
source: https://github.com/primer/react/blob/main/src/CheckboxGroup/CheckboxGroup.tsx
Expand Down
7 changes: 4 additions & 3 deletions docs/content/Dialog2.mdx → docs/content/Dialog.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: Dialog v2
title: Dialog
componentId: dialog
status: Alpha
---

Expand Down Expand Up @@ -53,7 +54,7 @@ By default, the Dialog component implements the design and interactions defined
<>
<Button onClick={openDialog}>Open</Button>
{isOpen && (
<Dialog2
<Dialog
title="Dialog example"
subtitle={
<>
Expand All @@ -64,7 +65,7 @@ By default, the Dialog component implements the design and interactions defined
onClose={closeDialog}
>
<Text fontFamily="sans-serif">Some content</Text>
</Dialog2>
</Dialog>
)}
</>
)
Expand Down
18 changes: 10 additions & 8 deletions docs/content/FilteredSearch.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,16 @@ The FilteredSearch component helps style a Dropdown and a TextInput side-by-side

```jsx live
<FilteredSearch>
<Dropdown>
<Dropdown.Button>Filter</Dropdown.Button>
<Dropdown.Menu direction="sw">
<Dropdown.Item>Item 1</Dropdown.Item>
<Dropdown.Item>Item 2</Dropdown.Item>
<Dropdown.Item>Item 3</Dropdown.Item>
</Dropdown.Menu>
</Dropdown>
<ActionMenu>
<ActionMenu.Button as="summary">Filter</ActionMenu.Button>
<ActionMenu.Overlay>
<ActionList direction="sw">
<ActionList.Item>Item 1</ActionList.Item>
<ActionList.Item>Item 2</ActionList.Item>
<ActionList.Item>Item 3</ActionList.Item>
</ActionList>
</ActionMenu.Overlay>
</ActionMenu>
<TextInput icon={SearchIcon} />
</FilteredSearch>
```
Expand Down
1 change: 1 addition & 0 deletions docs/content/IconButton.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: IconButton
componentId: icon_button
status: Alpha
source: https://github.com/primer/react/tree/main/src/Button2
storybook: '/react/storybook?path=/story/composite-components-button2'
Expand Down
107 changes: 0 additions & 107 deletions docs/content/LinkButton.mdx

This file was deleted.

1 change: 1 addition & 0 deletions docs/content/PageLayout.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: PageLayout
componentId: page_layout
status: Alpha
# description: TODO
source: https://github.com/primer/react/tree/main/src/PageLayout
Expand Down
6 changes: 3 additions & 3 deletions docs/content/Popover.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ import {Popover} from '@primer/react'

```jxs live
<Box position="relative">
<Text textAlign="center" display="block">
<ButtonPrimary>Hello!</ButtonPrimary>
</Text>
<Box justifyContent="center" display="flex">
<Button variant="primary">Hello!</Button>
</Box>
<Popover relative open={true} caret="top">
<Popover.Content sx={{mt: 2}}>
Expand Down
1 change: 1 addition & 0 deletions docs/content/RadioGroup.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: RadioGroup
componentId: radio_group
description: Renders a set of radio inputs to let users make a single selection from a short list of options
status: Alpha
source: https://github.com/primer/react/blob/main/src/RadioGroup/RadioGroup.tsx
Expand Down
4 changes: 2 additions & 2 deletions docs/content/SelectPanel.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ function DemoComponent() {
return (
<SelectPanel
renderAnchor={({children, 'aria-labelledby': ariaLabelledBy, ...anchorProps}) => (
<DropdownButton aria-labelledby={` ${ariaLabelledBy}`} {...anchorProps}>
<Button trailingIcon={TriangleDownIcon} aria-labelledby={` ${ariaLabelledBy}`} {...anchorProps}>
{children || 'Select Labels'}
</DropdownButton>
</Button>
)}
placeholderText="Filter Labels"
open={open}
Expand Down
30 changes: 16 additions & 14 deletions docs/content/SubNav.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,22 @@ This ensures that the NavLink gets `activeClassName='selected'`
```jsx live
<SubNav aria-label="Main">
<FilteredSearch>
<Dropdown>
<Dropdown.Button>Filter</Dropdown.Button>
<Dropdown.Menu direction="sw">
<Dropdown.Item>
<a href="#">Item 1</a>
</Dropdown.Item>
<Dropdown.Item>
<a href="#">Item 2</a>
</Dropdown.Item>
<Dropdown.Item>
<a href="#">Item 3</a>
</Dropdown.Item>
</Dropdown.Menu>
</Dropdown>
<ActionMenu>
<ActionMenu.Button>Filter</ActionMenu.Button>
<ActionMenu.Overlay>
<ActionList direction="sw">
<ActionList.Item>
<a href="#">Item 1</a>
</ActionList.Item>
<ActionList.Item>
<a href="#">Item 2</a>
</ActionList.Item>
<ActionList.Item>
<a href="#">Item 3</a>
</ActionList.Item>
</ActionList>
</ActionMenu.Overlay>
</ActionMenu>
<TextInput type="search" icon={SearchIcon} width={320} />
</FilteredSearch>
<SubNav.Links>
Expand Down
3 changes: 1 addition & 2 deletions docs/content/deprecated/ActionList.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
componentId: action_list
title: ActionList
title: ActionList (legacy)
status: Deprecated
source: https://github.com/primer/react/tree/main/src/deprecated/ActionList
---
Expand Down
3 changes: 1 addition & 2 deletions docs/content/deprecated/ActionMenu.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
componentId: action_menu
title: ActionMenu
title: ActionMenu (legacy)
status: Deprecated
source: https://github.com/primer/react/tree/main/src/deprecated/ActionMenu.tsx
---
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/BorderBox.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: border_box
title: BorderBox
status: Deprecated
---
Expand Down
3 changes: 1 addition & 2 deletions docs/content/deprecated/Buttons.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
componentId: button
title: Button
title: Button (legacy)
status: deprecated
source: https://github.com/primer/react/blob/main/src/Button
storybook: '/react/storybook?path=/story/composite-components-button--default-button'
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/ChoiceInputField.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: choiceInputField
title: ChoiceInputField
status: Deprecated
description: The ChoiceInputField component is used to render a labelled checkbox or radio inputs with optional hint text.
Expand Down
12 changes: 5 additions & 7 deletions docs/content/deprecated/Dialog.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: Dialog
title: Dialog (legacy)
status: Deprecated
---

## Deprecation

Use [Dialog2](/Dialog2) instead.
Use the [new version of Dialog](/Dialog) instead.

**Before**

Expand All @@ -23,7 +23,7 @@ Use [Dialog2](/Dialog2) instead.
```jsx deprecated
{
open && (
<Dialog2
<Dialog
title="Dialog example"
subtitle={
<>
Expand All @@ -34,13 +34,11 @@ Use [Dialog2](/Dialog2) instead.
onClose={() => setOpen(false)}
>
<Text fontFamily="sans-serif">Some content</Text>
</Dialog2>
</Dialog>
)
}
```

import State from '../../components/State'

The dialog component is used for all modals. It renders on top of the rest of the app with an overlay.

You'll need to manage the `isOpen` state in a wrapper component of your own and pass in a function to be used to close the Dialog. For documentation purposes only we've created a mock `State` to handle this, but you should handle the state in the component you consume `Dialog` in or in a wrapper component.
Expand Down Expand Up @@ -111,7 +109,7 @@ You can also pass any non-text content into the header:
</Text>
<Box display="flex" mt={3} justifyContent="flex-end">
<Button sx={{mr: 1}}>Cancel</Button>
<ButtonDanger>Delete</ButtonDanger>
<Button variant="danger">Delete</Button>
</Box>
</Box>
</Dialog>
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/DropdownMenu.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: dropdown_menu
title: DropdownMenu
status: Deprecated
---
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/Flex.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: flex
title: Flex
status: Deprecated
---
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/FormGroup.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: form_group
title: FormGroup
status: Deprecated
---
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/Grid.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: grid
title: Grid
status: Deprecated
---
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/InputField.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: inputField
title: InputField
status: Deprecated
description: The InputField component is used to render a labelled text input and, optionally, associated validation text and hint text.
Expand Down
2 changes: 1 addition & 1 deletion docs/content/deprecated/Label.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: Label
title: Label (legacy)
description: Use Label components to add contextual metadata to a design.
status: Deprecated
source: https://github.com/primer/react/blob/main/src/Label.tsx
Expand Down
1 change: 0 additions & 1 deletion docs/content/deprecated/Position.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
componentId: position
title: Position
status: Deprecated
---
Expand Down
Loading

0 comments on commit d4d98cf

Please sign in to comment.