Skip to content

Commit

Permalink
fix(Spinner): update container to use span instead of div (#4692)
Browse files Browse the repository at this point in the history 
* fix(Spinner): update container to use span instead of div

* test: update snapshots

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
  • Loading branch information
@joshblack
joshblack and joshblack committed Jun 21, 2024
1 parent 48b43d8 commit af1cc73
Show file tree
Hide file tree
Showing 4 changed files with 83 additions and 83 deletions.
2 changes: 1 addition & 1 deletion packages/react/src/Spinner/Spinner.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function Spinner({size: sizeKey = 'medium', srText = 'Loading', 'aria-label': ar

return (
/* inline-flex removes the extra line height */
<Box sx={{display: 'inline-flex'}}>
<Box as="span" sx={{display: 'inline-flex'}}>
<svg
height={size}
width={size}
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ exports[`snapshots renders a loading state 1`] = `
className="c1"
display="flex"
>
<div
<span
className="c2"
>
<svg
Expand Down Expand Up @@ -408,7 +408,7 @@ exports[`snapshots renders a loading state 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>,
]
Expand Down
80 changes: 40 additions & 40 deletions packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4094,7 +4094,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c3"
display="flex"
>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -4134,7 +4134,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -4308,7 +4308,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c3"
>
<svg
Expand Down Expand Up @@ -4348,7 +4348,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand All @@ -4365,7 +4365,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c3"
>
<svg
Expand Down Expand Up @@ -4405,7 +4405,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -4580,7 +4580,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c3"
display="flex"
>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -4620,7 +4620,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -4828,7 +4828,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -4873,7 +4873,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand All @@ -4890,7 +4890,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -4930,7 +4930,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -5138,7 +5138,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -5183,7 +5183,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand All @@ -5200,7 +5200,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -5240,7 +5240,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -5448,7 +5448,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -5493,7 +5493,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand All @@ -5510,7 +5510,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -5550,7 +5550,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -5759,7 +5759,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c5"
>
<svg
Expand Down Expand Up @@ -5804,7 +5804,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -5987,7 +5987,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
className="c2"
display="flex"
>
<div
<span
className="c3"
>
<svg
Expand Down Expand Up @@ -6027,7 +6027,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand Down Expand Up @@ -6069,7 +6069,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c3"
>
<svg
Expand Down Expand Up @@ -6114,7 +6114,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -6323,7 +6323,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c5"
>
<svg
Expand Down Expand Up @@ -6368,7 +6368,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -6594,7 +6594,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -6639,7 +6639,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand Down Expand Up @@ -6681,7 +6681,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -6726,7 +6726,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -6943,7 +6943,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -6988,7 +6988,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand Down Expand Up @@ -7030,7 +7030,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -7075,7 +7075,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down Expand Up @@ -7299,7 +7299,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -7344,7 +7344,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
<input
Expand Down Expand Up @@ -7386,7 +7386,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
/>
</svg>
</div>
<div
<span
className="c4"
>
<svg
Expand Down Expand Up @@ -7431,7 +7431,7 @@ exports[`TextInput renders with a loading indicator 1`] = `
>
Loading
</span>
</div>
</span>
</div>
</span>
</span>,
Expand Down
Loading

0 comments on commit af1cc73

Please sign in to comment.