Remove options when ending focus management

[JelloBagel]

Context

• Related to: Add IterateFocusableElements options to focusZone #235
• Related to: https://github.com/github/repos/issues/11731

What are you trying to accomplish?

Fix bug found when removing nodes in a focus zone and with strict mode enabled. Also, I added a test to check for this.

What approach did you choose and why?

We were running into focus inconsistencies when using useFocusZone in our component. I pinpointed it to this line

      if (removedNode instanceof HTMLElement) {
          endFocusManagement(...iterateFocusableElements(removedNode, iterateFocusableElementsOptions))
       }

where an empty array was being returned from

         iterateFocusableElements(removedNode, iterateFocusableElementsOptions)

and the endFocusManagement is unable to remove the focusable elements causing jumpy focus behavior for the user.

This was because in our component, we passed strict=true in the iterateFocusableElementsOptions object, which hits these lines of strict checks inside iterateFocusableElements. Because the node no longer existed/was removed, the strict check failed and returned an empty array.

I removed the iterateFocusableElementsOptions argument so when a node is removed all focusable elements within it are removed from the focusableElements list

[changeset-bot]

🦋 Changeset detected

Latest commit: 7d2d85f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/behaviors	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[TylerJDev]

LGTM!