-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed excessive spaces after line prefixes for unordered lists in Markdown #15526
base: main
Are you sure you want to change the base?
Conversation
5645761
to
1b94310
Compare
Hello @fisker, what can I do to push this PR forward? |
Hi, |
Any progress on this? I would really like to see this feature! |
@TomasLudvik @fisker what's the status on this PR? This is the one problem preventing Prettier adoption at our org. |
@glenn-jocher It is waiting for review from @fisker or @sosukesuzuki as I am not a maintainer of this repo. |
Hi @fisker, @sosukesuzuki |
Hi @fisker, @sosukesuzuki, I really hate to pester, but this is causing some immense grief with having to manually remove the extra spaces after the markers, is there anything anyone can do to push this forward? The deviation fights with basically every example and other linting tool out there as shown in a comment in #5019 which makes it a near impossible sell to match the other way round. |
@fisker @sosukesuzuki please merge this PR as soon as you can without further delay. |
Prettier messes up unordered lists due to prettier/prettier#5019, pending a fix in prettier/prettier#15526
* Copy-edited POSH policy * Remove extra spaces * Ignore Markdown files in Prettier Prettier messes up unordered lists due to prettier/prettier#5019, pending a fix in prettier/prettier#15526
@fisker @sosukesuzuki another bump for getting this PR merged 🙏 |
I'm not familiar with the markdown spec, but will this break CommonMark? |
I'm not sure about this change TBH. If I understand it correctly, it essentially ignores {
"tabWidth": 4, // prerequisite
"overrides": [
{
"files": "*.md",
"options": {
"tabWidth": 2
}
}
]
} That said, I’m not certain enough to say that this PR is wrong. I’m just confused about it’s best to ignore |
@fisker @kachkaev guys the #5019 bug that this PR fixes has 130 upvotes in #5019 (comment), many many users are facing problems that this PR fixes. The basic problem is that ![]() |
@fisker @sosukesuzuki @kachkaev friendly bump to please merge this. Our 80k-star organization is pending this PR to apply prettier to all our 300 MkDocs pages, it would really help us a lot. Currently we are considering installing prettier directly from @TomasLudvik fork instead, but this is much slower, i.e. |
@fisker Actually, this PR makes prettier closer to what Commonmark shows in its tutorials: see #5019 (comment) . @kachkaev , this PR in facts works together with tabwidth instead of a replacement. The indent is handled by tabwidth, but the spaces behind the marker should be handled independent of this as that is not an indentation (see comment above by @glenn-jocher ). |
@fisker friendly nudge here to please merge this PR when you can, thank you! |
wait the prettier issue be fixed prettier/prettier#15526
Description
This change fixes excessive spaces after line prefixes for unordered lists in Markdown. Closes #5019.
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨