This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(statusTile): Display status bar tile only if active file matches…
… one of the scopes (file extens Fixes #170
- Loading branch information
Showing
14 changed files
with
98 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use strict'; | ||
|
||
var _require = require('../editorInterface'), | ||
getCurrentScope = _require.getCurrentScope; | ||
|
||
var _require2 = require('../atomInterface'), | ||
getAllScopes = _require2.getAllScopes; | ||
|
||
var updateStatusTileScope = function updateStatusTileScope(element, editor) { | ||
if (element) { | ||
// The editor can be undefined if there is no active editor (e.g. closed all tabs). | ||
// eslint-disable-next-line no-param-reassign | ||
element.dataset.prettierMatchScope = editor !== undefined && getAllScopes().includes(getCurrentScope(editor)) ? 'true' : 'false'; | ||
} | ||
}; | ||
|
||
module.exports = updateStatusTileScope; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
// @flow | ||
const createStatusTile = require('./createStatusTile'); | ||
const updateStatusTile = require('./updateStatusTile'); | ||
const updateStatusTileScope = require('./updateStatusTileScope'); | ||
const { disposeTooltip } = require('./tooltip'); | ||
|
||
module.exports = { | ||
createStatusTile, | ||
updateStatusTile, | ||
updateStatusTileScope, | ||
disposeTooltip, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// @flow | ||
const { getCurrentScope } = require('../editorInterface'); | ||
const { getAllScopes } = require('../atomInterface'); | ||
|
||
const updateStatusTileScope = (element: HTMLElement, editor: TextEditor) => { | ||
if (element) { | ||
// The editor can be undefined if there is no active editor (e.g. closed all tabs). | ||
// eslint-disable-next-line no-param-reassign | ||
element.dataset.prettierMatchScope = editor !== undefined && | ||
getAllScopes().includes(getCurrentScope(editor)) | ||
? 'true' | ||
: 'false'; | ||
} | ||
}; | ||
|
||
module.exports = updateStatusTileScope; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
jest.mock('../atomInterface'); | ||
jest.mock('../editorInterface'); | ||
|
||
const { getCurrentScope } = require('../editorInterface'); | ||
const { getAllScopes } = require('../atomInterface'); | ||
const updateStatusTileScope = require('./updateStatusTileScope'); | ||
|
||
const callUpdateStatusTileScope = () => { | ||
const div = { dataset: {} }; | ||
const editor = {}; | ||
|
||
updateStatusTileScope(div, editor); | ||
|
||
return { div, editor }; | ||
}; | ||
|
||
beforeEach(() => { | ||
getAllScopes.mockImplementation(() => ['source.js']); | ||
}); | ||
|
||
it('sets the match-scope data attribute to true if the editor is in scope', () => { | ||
getCurrentScope.mockImplementation(() => 'source.js'); | ||
const { div } = callUpdateStatusTileScope(); | ||
expect(div.dataset.prettierMatchScope).toBe('true'); | ||
}); | ||
|
||
it('sets the match-scope data attribute to false if the editor is out of scope', () => { | ||
getCurrentScope.mockImplementation(() => 'source.html'); | ||
const { div } = callUpdateStatusTileScope(); | ||
expect(div.dataset.prettierMatchScope).toBe('false'); | ||
}); |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
div { | ||
// Active file not in supported scopes: hide tile. | ||
&[data-prettier-match-scope="false"] { | ||
display: none; | ||
} | ||
|
||
// If Format on Save is enabled, make the label more visible. | ||
&[data-prettier-format-on-save="enabled"] { | ||
color: #8BC34A; | ||
&::after { | ||
content: " ✓"; | ||
} | ||
} | ||
} |