Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "none" as an option for attributeSeparator #116

Merged

Conversation

lehni
Copy link
Collaborator

@lehni lehni commented Sep 27, 2020

Closes #102

@lehni lehni force-pushed the feature/allow-none-for-attribute-separator branch from d70b260 to 0d9873a Compare September 27, 2020 22:08
@lehni lehni force-pushed the feature/allow-none-for-attribute-separator branch from 0d9873a to dd7df8e Compare September 27, 2020 22:29
@Shinigami92
Copy link
Member

I need to investigate why the checks / tests are not running

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You should add a test case were attributes starting with : and @ are on a wrapped own line
  • You should add an extra pug-file test that contains e.g. (click) (angular syntax) as a non first attribute
    If this tests break with an exception, you should expect this in the tests AND add a warning note for users in the README.md

@Shinigami92
Copy link
Member

Can you try to just use push instead of force-push? I use squash merges anyway...
Maybe this will activate the checks

@lehni
Copy link
Collaborator Author

lehni commented Sep 28, 2020

Oh yes, sorry about the force-pushes! I will work on this again tomorrow.

@lehni
Copy link
Collaborator Author

lehni commented Sep 28, 2020

@Shinigami92 this should be good to go now!

@Shinigami92 Shinigami92 self-requested a review September 29, 2020 06:28
@Shinigami92 Shinigami92 added the type: enhancement Functionality that enhances existing features label Sep 29, 2020
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I need to work on my .github/workflows/ci.yml so the checks will be triggered
Will let you know when you need to merge master into this branch (or maybe I can do this with a button click)

Edit: ok no button for me 🙁, so you need to merge the master branch into yours
That includes a CI change and updated dependencies (so also the outdated check will not fail)

@lehni
Copy link
Collaborator Author

lehni commented Sep 29, 2020

I'm trying to do so, but am dealing with this strange error currently:

git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/lehni/plugin-pug
 ! [remote rejected] master -> master (refusing to allow an OAuth App to create or update workflow `.github/workflows/ci.yml` without `workflow` scope)

@lehni
Copy link
Collaborator Author

lehni commented Sep 29, 2020

The weird part is that I'm not actually using OAuth, I'm using the command line directly?

@Shinigami92
Copy link
Member

But git pull worked?
Try a rebase instead 🤔 👀

@lehni
Copy link
Collaborator Author

lehni commented Sep 29, 2020

I had to switch from using https to ssh for the remote, and now it works. Very strange:

url = git@github.com:lehni/plugin-pug.git

@lehni
Copy link
Collaborator Author

lehni commented Sep 29, 2020

@Shinigami92 I finally managed to merge master into this, should go all green shortly 🤞

@Shinigami92 Shinigami92 merged commit 14a6b5d into prettier:master Sep 29, 2020
@lehni lehni deleted the feature/allow-none-for-attribute-separator branch July 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow "none" as an option for attributeSeparator
2 participants