Allow "none" as an option for attributeSeparator

[ziazon]

Request / Idea

pug does not require commas following the attribute definitions, so can we add one more setting option to attributeSeparator so it can be always || as-needed || none ?

Input

container(
  someAttribute="value",
  another="OtherValue"
)

Expected Output

container(
  someAttribute="value"
  another="OtherValue"
)

Additional Context

[Shinigami92]

'none' is the equivalent of 'as-needed'!
Something like 'none' can potentially BREAK your syntax ⚠️

e.g.:

div(
  class="test"
  :style="'color: red'"         // <- this line has a `:` and can break your code/syntax
)

[ziazon]

'none' is the equivalent of 'as-needed'!
Something like 'none' can potentially BREAK your syntax ⚠️

e.g.:

div(
  class="test"
  :style="'color: red'"         // <- this line has a `:` and can break your code/syntax
)

that just looks like something that shouldn't be done lol but I kind of surprised that breaks your code... what frameworks does that break? it doesn't in vue template="pug"

[Shinigami92]

Sorry for my rush comment yesterday :)

You can read some parts here #13

I tried following in pughtml (cause I use vue myself)

div(
  class="test"
  :bind="'bind'"
  :bind2="'bind2'"
  @click="click()"
  @click2="click2()"
)

Maybe the update pug-lexer from v4 to v5 made it more safe 🤔

Or maybe it always was only an angular problem 🤷‍♂️

I remember that pug-lint also complains about such problems
Need to rewatch this at work with my huge code base so I can test it in real world

Aside that, feel free to start with a PR
Should be simple, cause it's only a third option

plugin-pug/src/options/index.ts

Line 3 in 4795af5

export type AttributeSeparator = 'always' | 'as-needed';

If you need any help, feel free to ask and I can also start writing a CONTRIBUTING.md

[Shinigami92]

At least for the Vue syntax, something has apparently changed at some point 🤷‍♂️

[ziazon]

sounds good! sorry for the late response, it's been a busy couple weeks :) I'll see about posting a PR sometime next week. Thanks!

[lehni]

We've been using attributes with : as the v-bind short-hand in Vue Single File Components without any attribute separators in a large project for over two years, and not once was there a problem with that syntax. I'd be great to have the none option!

[lehni]

Thank you @Shinigami92 for the help with my PRs and the swift merge and release!