fix: a11y improvements #155
Conversation
…titution into fix/a11y
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #155 +/- ##
============================================
+ Coverage 81.31% 82.63% +1.31%
- Complexity 285 289 +4
============================================
Files 31 32 +1
Lines 1584 1589 +5
============================================
+ Hits 1288 1313 +25
+ Misses 296 276 -20 |
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
There was a problem hiding this comment.
Two suggested changes.
One other issue is that I realized that the button which dismisses the error notice is included in the announced message because I think WordPress inserts it dynamically after load just like the other content is inserted. This is what's announced when I try to create two institutions both called "Dal":
I would suggest for these you could remove the is-dismissable class. WordPress adds role="alert" to them dynamically so creating a live region within the notice that doesn't include the dismiss button wouldn't work.
| <p>{{ $result['message'] }}</p> | ||
| <div | ||
| id="message" | ||
| role="status" |
There was a problem hiding this comment.
This should be role="alert". It also doesn't seem to be necessary as WordPress adds this dynamically/
|
Code LGTM |
Issue: #129
This PR addresses some of the suggestions mentioned in: #129.