fix: replace title with screen reader information

pressbooks · Apr 11, 2024 · 1c0db6b · 1c0db6b
1 parent ca7033b
commit 1c0db6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/resources/views/institutions/form.blade.php b/resources/views/institutions/form.blade.php
@@ -252,13 +252,15 @@ class="regular-text"
 						<input
 							name="book_limit"
 							id="book_limit"
-							title="{{ __('Only numbers are allowed', 'pressbooks-multi-institution') }}"
 							type="text"
 							inputmode="numeric"
 							pattern="[0-9]*"
-							aria-describedby="book_limit-description"
+							aria-describedby="book_limit-description book_limit-input-instruction"
 							value="{{ $old['book_limit'] ?? $institution->book_limit }}"
 						/>
+						<span class="screen-reader-text" id="book_limit-input-instruction">
+							{{ __('Only numbers are allowed.', 'pressbooks-multi-institution') }}
+						</span>
 					</td>
 				</tr>
 			@endif

diff --git a/src/Controllers/InstitutionsController.php b/src/Controllers/InstitutionsController.php
@@ -229,7 +229,7 @@ protected function validate(array $data, ?int $id): array
         return $errors;
     }
 
-    protected function nameExists(string $name, ?int $id): bool
+    protected function nameExists(?string $name, ?int $id): bool
     {
         return Institution::query()
             ->where('name', $name)