This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
WIP: create new book #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
============================================
- Coverage 77.42% 76.00% -1.43%
- Complexity 285 330 +45
============================================
Files 9 9
Lines 1032 1175 +143
============================================
+ Hits 799 893 +94
- Misses 233 282 +49
Continue to review full report at Codecov.
|
cagp-dev-mtl
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Enable createbook request handler * WIP: create new book (#84) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * Pb 81 lti create new book (#89) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * Pb 81 lti create new book (#90) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * fix display book, authenticate user in createbook action * Fix indentation, remove extra lines and add composer fix command * Fix indentation Co-authored-by: Brad <brad@bradpayne.ca>
cagp-dev-mtl
pushed a commit
that referenced
this pull request
Jul 10, 2020
* Enable createbook request handler * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * WIP: create new book (#84) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * Pb 81 lti create new book (#89) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * fix display book, authenticate user in createbook action Co-authored-by: bdolor <brad@bradpayne.ca>
cagp-dev-mtl
pushed a commit
that referenced
this pull request
Jul 10, 2020
* Enable createbook request handler * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * WIP: create new book (#84) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * Pb 81 lti create new book (#89) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * fix display book, authenticate user in createbook action * Pb 81 lti create new book (#90) * move processRequest to its own method * stub out createbook class * book creation working * add test and improvments for buildTitle * remove code, commented out * add initial test for maybeDisambiguateDomain * fix build * attend to contstraints, exit strategies and book validation * add test for validateLtiBookExists, clean up fuzzy * fix fuzzyMatch, start test function for fuzzy * move createbook into its own method, clean up * fix disambiguation regression, remove invalid test * correct declaration reference * improve conformance with lti spec * remove unwanted user match methods, get role from settings * add logic and tests for edge case * add more unit tests * add initial unit test for processRequest * remove unnecessary function * improve buildAndValidate with better title sanitization * fix tests, update doc blocks, add options, better validateLtiBooksExists * add more coverage for validateLtiBookExists * clean up comments, add display logic * add more coverage for processRequest * formatting, constants, code review clean up * remove trailing lines * fix display book, authenticate user in createbook action * Fix indentation, remove extra lines and add composer fix command * Fix indentation Co-authored-by: bdolor <brad@bradpayne.ca>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress for #81