Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Fix: pb_latest_export_filetypes #31

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix: pb_latest_export_filetypes #31

merged 1 commit into from
Jan 16, 2019

Conversation

dac514
Copy link
Contributor

@dac514 dac514 commented Jan 15, 2019

No description provided.

@dac514
Copy link
Contributor Author

dac514 commented Jan 15, 2019 •
edited
Loading

The error is coming from check_epubcheck_install which this plugin doesn't use.

What changed?

@greatislander
Copy link
Contributor

Maybe this? pressbooks/pressbooks@48622cb

@greatislander greatislander self-requested a review January 15, 2019 18:45
@greatislander greatislander added the bug Something isn't working label Jan 15, 2019
@greatislander greatislander added this to the 1.2.0 milestone Jan 15, 2019
@greatislander greatislander mentioned this pull request Jan 16, 2019
Merged
greatislander pushed a commit to pressbooks/pressbooks that referenced this pull request Jan 16, 2019
Prevent false positive for EPUBCheck (resolve #1524) (#1556)
b26cea5 
See:

+ #1524 (comment)
+ pressbooks/pressbooks-lti-provider#31 (comment)
greatislander pushed a commit to pressbooks/pressbooks that referenced this pull request Jan 16, 2019
Prevent false positive for EPUBCheck (resolve #1524) (#1556)
45dae15 
See:

+ #1524 (comment)
+ pressbooks/pressbooks-lti-provider#31 (comment)
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #31 into dev will increase coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #31      +/-   ##
============================================
+ Coverage     74.02%   74.06%   +0.03%     
- Complexity      276      280       +4     
============================================
  Files             9        9              
  Lines           951      964      +13     
============================================
+ Hits            704      714      +10     
- Misses          247      250       +3
Impacted Files Coverage Δ Complexity Δ
inc/class-table.php 33.96% <0%> (ø) 26 <0> (ø) ⬇️
inc/class-admin.php 81.58% <76.92%> (-0.27%) 79 <4> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0458b...d78971e. Read the comment docs.

@greatislander greatislander merged commit 7c93e06 into dev Jan 16, 2019
@greatislander greatislander deleted the pb_latest_export_filetypes branch January 16, 2019 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greatislander greatislander greatislander approved these changes

Assignees

@dac514 dac514

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dac514 @greatislander