Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Replacing whitelist for allowlist in template #113

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

richard015ar
Copy link
Contributor

Related issue: pressbooks/ideas#323
Small change in template to replace "Whitelist" string.

@richard015ar richard015ar requested a review from a team November 5, 2020 18:48
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #113 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #113   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
  Complexity      327      327           
=========================================
  Files             9        9           
  Lines          1169     1169           
=========================================
  Hits            924      924           
  Misses          245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab5f2...1f2cede. Read the comment docs.

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix label:

<em>{{ __("If you want to limit automatic registrations to certain domains add them here, one domain per line. If the whitelist is empty then automatic registrations are disabled.", 'pressbooks-lti-provider') }}</em>
"If whitelist is empty" should become "If allowlist is empty"

@richard015ar
Copy link
Contributor Author

@SteelWagstaff thank you catching it. I just fixed it.

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteelWagstaff SteelWagstaff merged commit d0c87f3 into dev Nov 6, 2020
@SteelWagstaff SteelWagstaff deleted the pbi-323-blackAndWhiteList branch December 13, 2021 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants