Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shape shifter compatibility #19

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Jan 5, 2023

Issue pressbooks/ideas#431

This PR adds compatibility with the shape shifter feature allowing users to change the typography of the theme.

How to test

  1. Enable Donham theme in Appearance > Themes
  2. Visit the book's page and the theme should be applied normally without changes
  3. Visit Appearance > Theme Options and change the font for Web, PDF, and EPUB
  4. Visit the book's page once more and validate the font was modified accordingly
  5. Generate PDF/EPUB exports and make sure changes are reflected in the exports as well

@SteelWagstaff SteelWagstaff merged commit 2d4b41e into dev Jan 5, 2023
@SteelWagstaff SteelWagstaff deleted the feat/shape-shifter-compatible branch January 5, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants