Table fix indexof #970
Merged
Table fix indexof #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvandijck
force-pushed
the
table-fix-indexof
branch
from
c8e9fab
to
c8abc67
Compare
tvandijck
force-pushed
the
table-fix-indexof
branch
from
c8abc67
to
177c2f1
Compare
starkos
approved these changes
Dec 12, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtle, and this loop works as long as the table is a pure array...
but once you use the table.insertkeyed, or a mix of hashmap/array this can potentially return just a key of any type, not just the index to an element in the array part.