Improve uuid generation on Linux #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Apr 29, 2022
|
One more note I've just realized: the 6.x branch uses the same generation code, so this could also be applied there. If y'all want I can do another pr implementing it. It would be basically the same code change and the only real difference I can see would be in the build files |
nickclark2016
approved these changes
May 6, 2022
|
Feel free to stick out a PR for v6. Given UUID has been around since 2009, I think we're good. That was 13 years ago. |
|
Merging. |
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes use of Linux's uuid header to generate a uuid instead of reading from
/dev/urandom.How does this PR change Premake's behavior?
No breaking changes or behavior differences should occur.
Anything else we should know?
This does create the requirement of having the
libuuid/uuid-devpackage in order to buildDid you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!