Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate whether orjson casting still is necessary with more recent orjson versions #118

Open
jonasvdd opened this issue Sep 10, 2022 · 1 comment
Open

Validate whether orjson casting still is necessary with more recent orjson versions #118

jonasvdd opened this issue Sep 10, 2022 · 1 comment

Comments

@jonasvdd
Copy link
Member

plotly-resampler/plotly_resampler/figure_resampler/figure_resampler_interface.py

Lines 703 to 705 in 5df40fd

# orjson encoding doesn't like to encode with uint8 & uint16 dtype
if str(hf_y.dtype) in ["uint8", "uint16"]:
hf_y = hf_y.astype("uint32")

Maybe also make a test which validates this? (expected behavior -> casting is needed)
@jonasvdd
Copy link
Member Author

image

woah, my spider senses are on par! 💪🏼

jonasvdd added a commit that referenced this issue Oct 31, 2022
@jonasvdd
💪 making orjson serialization more robust, see #118
355fbec
jonasvdd added a commit that referenced this issue Nov 8, 2022
@jonasvdd
Merge pull request #131 from predict-idlab/orjson_werkzeug
3d6b49a 
💪🏼  making orjson serialization more robust, see #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasvdd