[perf] Improve string encoding performance by ~50% #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity encoding is a large portion of time spent, since we encode all attribute values and text nodes. This switches encoding from multiple regular expressions to a linear forward scan.
🦋 Changeset detectedLatest commit: e4fe799 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jul 21, 2022
marvinhagemeister
approved these changes
Jul 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity encoding is a large portion of time spent, since we encode all attribute values and text nodes.
This switches encoding from multiple regular expressions to a linear forward scan.
In the benchmark below, the previous algorithm is the second bar ("replace"), and the new algorithm is the last bar ("scanSegments 2"):
Note: This doesn't show up in our two benchmarks here, because there are no entities present in the text or attributes in those benchmarks.