Added floating text program #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please see the codacy PR reviews. There's some issue on the os.system("cls") |
|
Okay Thank You. |
|
No need to send a PR again, You can edit that in this PR only |
|
All the checks are passed. |
prateekiiest
requested changes
Dec 6, 2017
| "* ", | ||
| " *** ", | ||
| " *", | ||
| "**** " ], |
There was a problem hiding this comment.
And remove the cls not found command.
Its obstructing the view
There was a problem hiding this comment.
The program is just for English alphabets.
There was a problem hiding this comment.
Okay, I will fix that.
|
The error in the gif is fixed. Please review it again. |
|
Can you review my PR #89 please. |
prateekiiest
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution. Please provide the details requested below.
ISSUE NUMBER
#41
#20
SHORT DESCRIPTION
Floating Text is a simple program which displays a given input String as a floating string on the terminal.
TESTING
cd floating_textpython floating_text.pyAdded a gif for your reference.