Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Deprecation for Pure Link Strings #238

Closed
RobertDober opened this issue May 18, 2019 · 1 comment
Closed

Implement Deprecation for Pure Link Strings #238

RobertDober opened this issue May 18, 2019 · 1 comment
Assignees
@RobertDober
Labels
deprecation
Milestone
1.4

Comments

@RobertDober
Copy link
Collaborator

RobertDober commented May 18, 2019 •
edited
Loading

  • Change default of option pure_links to true.
  • Remove deprecation warning in the case pure_links is falsy.

Related to #158
@RobertDober RobertDober added this to the 1.4 milestone May 18, 2019
@RobertDober RobertDober self-assigned this May 18, 2019
@tensiondriven
Copy link

"Imlement" in the title should be "Implement"

@RobertDober RobertDober changed the title Imlement Deprecation for Pure Link Strings Implement Deprecation for Pure Link Strings Jul 13, 2019
RobertDober added a commit that referenced this issue Sep 4, 2019
@RobertDober
Merge pull request #274 from pragdave/i238-pure-links-default
f829528 
Fixes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertDober RobertDober

Labels
deprecation
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@tensiondriven @RobertDober