Set custom scope for Docker build CI #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, interesting! Thanks for looking into this! |
bradlarsen
approved these changes
Apr 3, 2024
|
This probably improves the situation in #163. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
docker/build-push-actionusesbuildkitas a scope. In our Docker CI setup, we're building two images at the same time, and it seems that those caches were somehow overwritten in a way that they couldn't be reused. By setting the custom scope, the caching started working. In tests in my personal repo, the building time of the Debian image (one designed to use that caching well) went down from 9m 48s to 5m 41s.