Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a 'type: ignore' comment, for mypy #812

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jul 7, 2024

Trying to run nox -s lint on the project, I discovered that mypy doesn't like one particular return call because the type: ignore comment is on the wrong line.

Output before change

src/furo/__init__.py:311: error: Returning Any from function declared to return "Style"  [no-any-return]
src/furo/__init__.py:312: error: Unused "type: ignore" comment  [unused-ignore]

@pradyunsg pradyunsg merged commit 073c497 into pradyunsg:main Jul 7, 2024
2 checks passed
@pradyunsg
Copy link
Owner

Thanks @ferdnyc!

@ferdnyc ferdnyc deleted the fix-mypy branch July 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants