Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics for all buffers #982

Merged
merged 7 commits into from
Dec 28, 2020
Merged

Diagnostics for all buffers #982

merged 7 commits into from
Dec 28, 2020

Conversation

prabirshrestha
Copy link
Owner

@prabirshrestha prabirshrestha commented Dec 28, 2020

This is part of Diagnostics Revamp and vim-lsp 2020

This introduces a new flag to show diagnostics for all buffer using :LspDocumentDiagnostics --buffers=*. Documentation has more details.

  • implement support for show all document diagnostics for all buffers and servers
  • implement support for showing only the default buffer diagnostics
  • update documentation
  • respect disabled buffer
  • add unit tests
  • remove old code

image

Not in this PR but something for the future in case we would like to support it:

In the future we could have --ui=loclist or --ui=quickfix or even custom ui via lsp#register_ui to register curstom ui. For now this is out of scope since lot of ideas still need to be flushed out. But if folks want to use quickfix for all buffers we can easily implement --ui support for it without custom ui support.

One could then do :LspDocumentDiagnostics --ui=quickfix --servers=vim,efm --buffers=* --exclude-buffers=1,2

@prabirshrestha prabirshrestha mentioned this pull request Dec 28, 2020
15 tasks
@prabirshrestha prabirshrestha force-pushed the diagnostics-for-all branch 2 times, most recently from 453691d to fc33fbf Compare December 28, 2020 04:28
@prabirshrestha prabirshrestha merged commit 6bb6069 into master Dec 28, 2020
@prabirshrestha prabirshrestha deleted the diagnostics-for-all branch December 28, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant