elim unused param and use getrandom API. #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomwiggers
reviewed
Jul 28, 2021
| void randombytes(uint8_t *out, size_t outlen) { | ||
| ssize_t ret; | ||
|
|
||
| while(outlen > 0) { | ||
| ret = syscall(SYS_getrandom, out, outlen, 0); | ||
| ret = getrandom (out, outlen, 0); |
There was a problem hiding this comment.
this isn't using syscall by accident; it allows for use of getrandom on e.g. older versions of Ubuntu where getrandom() isn't available but the syscall does work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function randombytes_init included an unused parameter which has been removed.
In 2017, glibc added an API call for getrandom. This update checks the glibc version and uses the getrandom API call if available instead of making a syscall.