Add simulation criteria parameter #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
|
flo-dup
requested changes
Sep 11, 2024
| setCriteriaFilePath(criteriaPath); | ||
| } | ||
|
|
||
| public boolean hasCriteriaFile() { |
There was a problem hiding this comment.
you could use Optional<Path> as return type for getCriteriaFilePath instead
| void testIeee14WithSimulationCriteria() { | ||
|
|
||
| Supplier<DynamicSimulationResult> resultSupplier = setupIEEE14Simulation(); | ||
| dynawoSimulationParameters.setCriteriaFilePath(Path.of(Objects.requireNonNull(getClass().getResource("/ieee14/criteria.crt")).getPath())); |
There was a problem hiding this comment.
I tested with a wrong xml file and the test passes... Is there any way to see that the file was correctly taken into account @gautierbureau ?
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #309
Does this PR introduce a breaking change or deprecate an API?