Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources - part 4: documentation #3105

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Jul 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@rolnico rolnico changed the base branch from main to nro/datasources_3_new_features July 18, 2024 13:33
@rolnico rolnico self-assigned this Jul 18, 2024
@rolnico rolnico changed the title Datasources - part 4: documentation WIP: Datasources - part 4: documentation Jul 18, 2024
@flo-dup flo-dup force-pushed the nro/datasources_3_new_features branch from 47bf1a7 to 2a4ba27 Compare August 1, 2024 14:43
Base automatically changed from nro/datasources_3_new_features to main August 2, 2024 15:11
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@flo-dup flo-dup force-pushed the nro/datasources_4_documentation branch from 8916995 to 86fd669 Compare August 9, 2024 15:00
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
docs/index.md Outdated
@@ -22,6 +22,7 @@ grid_model/index.md
grid_features/index.md
simulation/index
data/timeseries
data/datasources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be deeper in the index, it's more for developers or expert users. Maybe a "going further" section in grid exchange formats

Copy link

sonarcloud bot commented Aug 9, 2024

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico marked this pull request as ready for review September 9, 2024 12:40
@rolnico rolnico changed the title WIP: Datasources - part 4: documentation Datasources - part 4: documentation Sep 9, 2024
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Copy link

sonarcloud bot commented Sep 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants