-
Notifications
You must be signed in to change notification settings - Fork 213
Automated movies and TV series search #324
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Implementing the suggested changes will enhance the readability. Please do so if possible.
|
||
#READ THE DOCUMENTATION FIRST, THEN MOVE ON TO THE SOURCE CODE AS DOCUMENTATION WILL BRIEF YOU ABOUT THE PYTHON MODULE, DATA STRUCTURES USED AND ALSO HOW TO WORK THROUGH THIS PROGRAM. | ||
|
||
"""For running this code you have to download IMDbPy package from google. IMDbPY is a Python package useful to retrieve and manage the data of the IMDb movie database about movies, people, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstrings should ideally be like this:-
"""
Your text here.
"""
characters and companies.Platform-independent and written in Python 3 it can retrieve data from both the IMDb’s web server and a local copy of the whole database. | ||
IMDbPY package can be very easily used by programmers and developers to provide access to the IMDb’s data to their programs.""" | ||
|
||
#For understanding this project you need to have a basic knowledge about python, definition of database, module, instances and lists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels unnecessary.
|
||
#For understanding this project you need to have a basic knowledge about python, definition of database, module, instances and lists. | ||
|
||
"""While running the code it asks for a movie or tv series name. After you enter the movie or a tv series name it returns a list of movies or tv series with its id which are related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix Docstring format.
try : | ||
for director in movies["directors"] : # try and except is used to prevent error messages that show up while compiling | ||
print(director["name"]) | ||
except : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please recheck if printing the name of the writers
goes within the except block and not the try
block?
@@ -0,0 +1,67 @@ | |||
#IT IS A MINI-IMDB PROJECT THAT PROVIDES INFORMATION ABOUT ANY MOVIE OR TV SERIES WHEN SEARCHED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely coded project. Please try and get the code formatting to PEP8 format for improved readability.
IT IS A MINI-IMDB PROJECT THAT PROVIDES INFORMATION ABOUT ANY MOVIE OR TV SERIES WHEN SEARCHED.
This project is coded in python language and uses basics of python data structure - lists, OOPS and some basics of database.
Do remember to read the documentation at the top of the source code for smooth learning.