Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Python script to get your current location #229

Closed
wants to merge 180 commits into from
Closed

Python script to get your current location #229

wants to merge 180 commits into from

Conversation

abhishek-pes
Copy link

Added a python scrip to get current location

PatelKeviin and others added 30 commits August 16, 2020 12:42
The user can type any statement for example if I want to add I can give input like : "Please add the numbers for me"
and the output after adding the particular numbers will be printed.
It is built to make interaction easier and not make it monotous for the user by typing only numerical values as choice rather giving any usual english statements.

It is a better version of Simple Calculator.
To get Sync with original project
@abhishek-pes
Copy link
Author

@ankitdobhal I have added the output in the readme file.

@Neilblaze
Copy link

Neilblaze commented Aug 30, 2020

Amazing work @abhishek-pes ! 🎉

Before I approve changes to the PR, I will request you the following changes mentioned below.

  • Create a separate branch before pushing the files into it.
  • Exclude the chromedriver.exe autogenerated file from the PR file.
  • Maintain proper Contribution protocols (ignore if you're already following it!) & good practices!

Rest LGTM 👍

  • nice & clean code 😄

Copy link

@Neilblaze Neilblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the .exe file & rest LGTM 👍

@abhishek-pes
Copy link
Author

@Neilblaze thanks a lot for the suggestions, also I have deleted the chromedriver.exe

@Neilblaze
Copy link

Amazing work @abhishek-pes !

Before I approve changes to the PR, I will request you the following changes mentioned below.

  • Create a separate branch before pushing the files into it.
  • Exclude the chromedriver.exe autogenerated file from the PR file.
  • Maintain proper Contribution protocols (ignore if you're already following it!) & good practices!

Rest LGTM

  • nice & clean code smile

@abhishek-pes please shift the pr folder to seperate branch as I mentioned earlier.

@abhishek-pes abhishek-pes changed the base branch from master to revert-146-amazon August 30, 2020 17:33
@abhishek-pes
Copy link
Author

abhishek-pes commented Aug 30, 2020

Amazing work @abhishek-pes !
Before I approve changes to the PR, I will request you the following changes mentioned below.

  • Create a separate branch before pushing the files into it.
  • Exclude the chromedriver.exe autogenerated file from the PR file.
  • Maintain proper Contribution protocols (ignore if you're already following it!) & good practices!

Rest LGTM

  • nice & clean code smile

@abhishek-pes please shift the pr folder to seperate branch as I mentioned earlier.

@Neilblaze sorry I missed it, so is this correct now?

@Neilblaze
Copy link

@abhishek-pes why didn't you perform the upstream of base branch before changing the base branch. As I can see the pr file still exists in the base branch. Fix this buddy!

@abhishek-pes
Copy link
Author

sorry iam still a beginner, so how do I fix this?

@abhishek-pes
Copy link
Author

@Neilblaze since iam still a beginner can you please help me in fixing this.

@Neilblaze
Copy link

Since you're not much familiar with git-cli, you do one thing save the pr file on your local & start anew. If get stuck then feel free to ping me on slack!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.