Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing large lists of symbols in model callback is slow #296

Closed
rkaminsk opened this issue Apr 21, 2021 · 0 comments
Closed

Storing large lists of symbols in model callback is slow #296

rkaminsk opened this issue Apr 21, 2021 · 0 comments
Assignees
@rkaminsk
Labels
enhancement
Milestone
v5.5.1

Comments

@rkaminsk
Copy link
Member

A common use case is to store the last model in the on_model callback. This works fine with the current API but a lot of intermediate Symbol objects are created. Given Python's incredibly slow object construction, it would be better to implement the symbol array in C.
@rkaminsk rkaminsk added this to the v5.5.1 milestone Apr 21, 2021
@rkaminsk rkaminsk self-assigned this Apr 21, 2021
rkaminsk added a commit that referenced this issue Apr 21, 2021
@rkaminsk
address #296
ea8ddd2 
This breaks backward compatibility because `Models.symbols` no longer
returns a list. Given the performance/memory problems with the previous
solutions it is hopefully worth it.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkaminsk rkaminsk

Labels
enhancement
Projects
None yet
Milestone
v5.5.1
Development

No branches or pull requests
1 participant
@rkaminsk