-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Replace UnCSS with fork #152
Comments
@NovaAtWarren What happened to the |
Collaborators with NPM access seem to have either stopped programming JS or just gone AWOL, as per this issue
On the 18th May, I opened pull 456, and while it got approved it never got merged.
I can't comment on removing UnCSS entirely, as I'm unfamiliar with alternative packages, I just know that some of my dependencies use UnCSS, and maintaining a version with updated dependencies was easier than replacing it in every dependency that used it. |
@NovaAtWarren I appreciate that you forked uncss and upgraded it! But let me be honest with you, I'm hesitant to replace the original uncss with a forked version that is not actively used by other people and which future is also unclear (e.g., will it be maintained in the future, etc). I'm not that familiar with the advanced features of npm, but maybe there is a way to replace uncss with your forked version on a per-project basis ( I'm also open to other solutions! |
I can understand your hesitation entirely. Edit: Additional idea, a forked-uncss branch. Whether I had write access or not, I could set a watch on this repo and just make a PR or pull changes across as and when they happen. Then, anyone installing the dependency doesn't have to modify it. They can just pull a different version (or a slightly different name on NPM) |
Sure. Sounds good to me! Would you provide it, please?
Sorry, I'm not quite sure how this would work. But, I think, it also sounds good to me! |
Sorry if I implied you'd make the patch, I do intend on writing it myself.
What I was thinking with that was making a new branch on this repo, and applying the patch to that branch. Uploading that branch to NPM whenever I'll get working on the patch |
Thanks a lot! |
I've created a fork of UnCSS to try and update some of the insecure dependencies, and to merge some PRs, as the original collaborators seem to not be performing said task.
As UnCSS (the version referenced by package.json) is unmaintained, and my fork is maintained, it may be a good idea to switch to decrease dependency on outdated packages.
I can make a PR if you desire.
The text was updated successfully, but these errors were encountered: